<table><tr><td style="">broulik added inline comments.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2470" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2470#inline-9922" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilupowerbackend.cpp:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">,</span> <span class="n">m_kbdMaxBrightness</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="p">,</span> <span class="n">m_lidIsPresent</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_lidIsClosed</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_onBattery</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">,</span> <span class="n">m_lidIsPresent</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_lidIsClosed</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_onBattery</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)<span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">m_isLedBrightnessControl</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #304a96"><span class="bright">false</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Put new var on a new line</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2470#inline-9923" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilupowerbackend.cpp:193</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                                <span class="n">m_isLedBrightnessControl</span> <span style="color: #aa2211">=</span> <span class="n">m_syspath</span><span class="p">.</span><span class="n">split</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">).</span><span class="n">contains</span><span class="p">(</span><span style="color: #766510">"leds"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                                <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_isLedBrightnessControl</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">splitRef and QLatin1String</p>

<p style="padding: 0; margin: 8px;">Can't you do contains("/leds/") to reduce the likelihood of false positives? Or can it also be /sys/class/ledsfoo/ or sth like that?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2470#inline-9925" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilupowerbackend.cpp:454</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">m_cachedBrightnessMap</span><span class="p">[</span><span class="n">Screen</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">value</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">slotScreenBrightnessChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Make sure you don't emit if it didn't actually change (dunno what the code does internally so might already check for that)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPOWERDEVIL Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2470" rel="noreferrer">https://phabricator.kde.org/D2470</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>bshah, Plasma, broulik<br /><strong>Cc: </strong>graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>