<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin added a reviewer: graesslin.<br />graesslin added inline comments.<br />This revision now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2462" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2462#inline-9859" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockScreen.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #004012">property</span> <span style="color: #004012">UserSelect</span> <span style="color: #aa4000">userSelect:</span> <span style="color: #000a65">null</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">interfaceVersion:</span> <span style="color: #004012">org_kde_plasma_screenlocker_greeter_interfaceVersion<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">org_kde_plasma_screenlocker_greeter_interfaceVersion :</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #004012">signal</span> <span style="color: #004012">clearPassword</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">interfaceVersion:</span> <span style="color: #004012">org_kde_plasma_screenlocker_greeter_interfaceVersion</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this change I don't understand. It's not described in the change.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2462#inline-9860" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockScreen.qml:59-63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #aa4000">Component.onCompleted:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">interfaceVersion</span> <span style="color: #aa2211"><</span> <span style="color: #601200">2</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span style="color: #004012">mainLoader</span><span class="p">.</span><span style="color: #004012">source</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"LockScreenUi.qml"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why is that removed?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2462" rel="noreferrer">https://phabricator.kde.org/D2462</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: </strong>graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>