<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2449" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2449#inline-9856" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lnflogic.cpp:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QDBusPendingCallWatcher</span> <span style="color: #aa2211">*</span><span class="n">watcher</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QDBusPendingCallWatcher</span><span class="p">(</span><span class="n">pcall</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">leaks</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2449#inline-9857" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lnflogic.cpp:155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">defaultsConfigGroup</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">defaultsConfigGroup</span><span class="p">,</span> <span style="color: #766510">"DesktopSwitcher"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">systemCG</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kwinrc"</span><span class="p">)),</span> <span style="color: #766510">"DesktopSwitcher"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">defaultsConfigGroup</span><span class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span style="color: #766510">"LayoutName"</span><span class="p">,</span> <span class="n">systemCG</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"LayoutName"</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"org.kde.breeze.desktop"</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's the wrong group name. <br />
It should be TabBox.</p>

<p style="padding: 0; margin: 8px;">(and if this is copy pastad from somewhere, then fix that too.)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2449#inline-9853" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #74777d">//usually we have an ApplicationWindow here, so we do not need to create a window by ourselves</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">KDeclarative</span><span style="color: #aa2211">::</span><span class="n">QmlObject</span> <span style="color: #aa2211">*</span><span class="n">obj</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KDeclarative</span><span style="color: #aa2211">::</span><span class="n">QmlObject</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">obj</span><span style="color: #aa2211">-></span><span class="n">setTranslationDomain</span><span class="p">(</span><span class="n">packagePath</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">leaks</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2449#inline-9855" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">qmlRegisterType</span><span style="color: #aa2211"><</span><span class="n">LnfLogic</span><span style="color: #aa2211">></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">qmlRegisterType</span><span style="color: #aa2211"><</span><span class="n">LnfListModel</span><span style="color: #aa2211">></span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">UncreatableType * 2</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2449#inline-9854" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">LnfLogic</span> <span style="color: #aa2211">*</span><span class="n">lnfLogic</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">LnfLogic</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">obj</span><span style="color: #aa2211">-></span><span class="n">engine</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">rootContext</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setContextProperty</span><span class="p">(</span><span style="color: #766510">"lnfLogic"</span><span class="p">,</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">fromValue</span><span class="p">(</span><span class="n">lnfLogic</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">leaks</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMASDK Plasma SDK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2449" rel="noreferrer">https://phabricator.kde.org/D2449</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>