<table><tr><td style="">ochurlaud created this revision.<br />ochurlaud added reviewers: Plasma, mart, andreask, VDG.<br />ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2409" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>As discussed with the VDG, the color KCM had to be split in a very simple KCM to choose a color scheme, and a color scheme editor.</p>

<h4 class="remarkup-header">What is here?</h4>

<ul class="remarkup-list">
<li class="remarkup-list-item">I rewrote/refactor almost all the code so that it's easier to understand (hopefully).</li>
<li class="remarkup-list-item">I created a standalone app to edit.</li>
</ul>

<h4 class="remarkup-header">Here are the current issues:</h4>

<ol class="remarkup-list">
<li class="remarkup-list-item">I reuse the headers/cpp files of the standalone app in the kcm. It would be better to directly call the app, but then I don't know how to repopulate the list when I'm done with the app (see in KColorCm::on_schemeEditButton_clicked)</li>
</ol>

<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">The standalone app has not a correct name (How should I call the executable and the app?)</li>
</ol>

<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">The standalone app doesn't have all the KAboutData + CommandParser things, because I'm a little lazy.</li>
</ol>

<p>To test directly, you can use the branch <tt style="background: #ebebeb; font-size: 13px;">andreas/kcm_update</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2409" rel="noreferrer">https://phabricator.kde.org/D2409</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/colors/CMakeLists.txt<br />
kcms/colors/colorscm.cpp<br />
kcms/colors/colorscm.h<br />
kcms/colors/colorsettings.ui<br />
kcms/colors/schemeeditor.cpp<br />
kcms/colors/scmeditorcolors.cpp<br />
kcms/colors/scmeditorcolors.h<br />
kcms/colors/scmeditorcolors.ui<br />
kcms/colors/scmeditordialog.cpp<br />
kcms/colors/scmeditordialog.h<br />
kcms/colors/scmeditordialog.ui<br />
kcms/colors/scmeditoreffects.cpp<br />
kcms/colors/scmeditoreffects.h<br />
kcms/colors/scmeditoreffects.ui<br />
kcms/colors/scmeditoroptions.cpp<br />
kcms/colors/scmeditoroptions.h<br />
kcms/colors/scmeditoroptions.ui</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>ochurlaud, Plasma, mart, andreask, VDG<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>