<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2391" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>TEST PLAN</strong><div><p>Wayland untested but compiled.</p>

<p>(btw, serviceCache.contains and then serviceCache.value performs a double lookup, QHash value returns a default-constructed value for not found entries, so could probably be simplified to?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KService::Ptr service = serviceCache.value(window);
if (service) {
    // ...
}</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2391" rel="noreferrer">https://phabricator.kde.org/D2391</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libtaskmanager/abstracttasksmodel.cpp<br />
libtaskmanager/abstracttasksmodel.h<br />
libtaskmanager/abstracttasksmodeliface.h<br />
libtaskmanager/concatenatetasksproxymodel.cpp<br />
libtaskmanager/concatenatetasksproxymodel.h<br />
libtaskmanager/flattentaskgroupsproxymodel.cpp<br />
libtaskmanager/flattentaskgroupsproxymodel.h<br />
libtaskmanager/launchertasksmodel.cpp<br />
libtaskmanager/launchertasksmodel.h<br />
libtaskmanager/taskfilterproxymodel.cpp<br />
libtaskmanager/taskfilterproxymodel.h<br />
libtaskmanager/taskgroupingproxymodel.cpp<br />
libtaskmanager/taskgroupingproxymodel.h<br />
libtaskmanager/tasksmodel.cpp<br />
libtaskmanager/tasksmodel.h<br />
libtaskmanager/waylandtasksmodel.cpp<br />
libtaskmanager/waylandtasksmodel.h<br />
libtaskmanager/windowtasksmodel.cpp<br />
libtaskmanager/windowtasksmodel.h<br />
libtaskmanager/xwindowtasksmodel.cpp<br />
libtaskmanager/xwindowtasksmodel.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>