<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128594/">https://git.reviewboard.kde.org/r/128594/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On August 3rd, 2016, 5:05 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Marco Martin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2016, 5:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This template should allow people to get a basic working wallpaper plugin within minutes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch (in separate commits) also
- updates the READMEs of the plasmoid templates to point to correct QML2 wiki pages.
- mobves the plasmoid and wallpaper templates into own toplevel category "Plasma/", out of "KDE/", given this is a platform target of its own</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Installed the template, then created a new wallpaper plugin using kapptemplate and following the README, then selected in wallpaper config, incl. editing the plugin config by entering a new text.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>templates/CMakeLists.txt <span style="color: grey">(b51777d)</span></li>
<li>templates/cpp-plasmoid/README <span style="color: grey">(d3582db)</span></li>
<li>templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate <span style="color: grey">(42924b0)</span></li>
<li>templates/plasma-wallpaper/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/package/contents/ui/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/qml-plasmoid/README <span style="color: grey">(6814263)</span></li>
<li>templates/qml-plasmoid/qml-plasmoid.kdevtemplate <span style="color: grey">(2675e71)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128594/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>