<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128596/">https://git.reviewboard.kde.org/r/128596/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This way we can use kpackagetool5 against them (see review 128590).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">NOTE to the attentive reviewer:
ShellPluginLoader wasn't properly ported. It's a class that is not adding anything to the plate now, using the base class works just as well and that can't be ported because now we have <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KPackage::PackageStructure</code> rather than <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Plasma::*</code>. Class left to maintain ABI but won't maintain behavior as is.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plasmashell still seems to work.
Tests pass.
A bunch of appdata files are installed from kdeplasma-addons.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/CMakeLists.txt <span style="color: grey">(e9215c1)</span></li>
<li>src/plasma/containmentactions.cpp <span style="color: grey">(3b9b76c)</span></li>
<li>src/plasma/package.cpp <span style="color: grey">(a3845b4)</span></li>
<li>src/plasma/packagestructure/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/containmentactions-packagestructure.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/containmentactionspackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/dataengine-packagestructure.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/dataenginepackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/packages.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/plasmageneric-packagestructure.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/plasmagenericpackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/plasmatheme-packagestructure.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/plasmathemepackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/plasmoid-packagestructure.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/packagestructure/plasmoidpackage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/plasma.cpp <span style="color: grey">(a6da2d5)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(6a9eb50)</span></li>
<li>src/plasma/private/packages.cpp <span style="color: grey">(0392e8d)</span></li>
<li>src/plasma/private/packages_p.h <span style="color: grey">(5c9dd7a)</span></li>
<li>src/plasma/theme.cpp <span style="color: grey">(e4a9e17)</span></li>
<li>src/plasmaquick/shellpluginloader.h <span style="color: grey">(d7e8079)</span></li>
<li>src/plasmaquick/shellpluginloader.cpp <span style="color: grey">(e660df9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128596/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>