<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 28, 2016 at 10:40 PM, Michail Vourlakos <span dir="ltr"><<a href="mailto:mvourlakos@gmail.com" target="_blank">mvourlakos@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">><br>
>> for DropShadow and the animation for hover to add it<br>
>> in the PlasmaCore.IconItem right?<br>
>><br>
><br>
> I'd put the animation in the DropShadow itself and scale that.<br>
><br>
> I bet changing the size of a ShaderEffectSource triggers a re-render, and<br>
> that's why you see the performance hit.<br>
><br>
> Currently you're changing the iconImageBuffer but the QSGTextureProvider it<br>
> created will just remain static.<br>
><br>
<br>
</span>the following code drops my performance to half comparing to the<br>
Images solution,<br>
do I miss something? :<br>
<br></blockquote><div><br><br></div><div>Move the IconItem outside the DropShadow.<br></div><div>Otherwise you're scaling the source still, which is what we want to avoid.<br></div><br><div>Out of curiosity, how are you measuring performance?<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
    DropShadow {<br>
        id:shadowImageNoActive<br>
<br>
        width: 64<br>
        height: 64<br>
<br>
        scale: wrapper.scale * wrapper.appearScale<br>
<br>
        anchors.centerIn: parent<br>
<br>
        radius: 7.0<br>
        samples: 10<br>
        color: "#90080808"<br>
        source: ShaderEffectSource {<br>
            id:effectSource<br>
            width: iconImage.width<br>
            height: iconImage.height<br>
            sourceItem: iconImage<br>
            hideSource: true<br>
            live: false<br>
        }<br>
<br>
        PlasmaCore.IconItem {<br>
            id: iconImage<br>
<br>
            width:64<br>
            height:64<br>
<br>
            anchors.centerIn: parent<br>
<span class="im HOEnZb"><br>
            active: true<br>
            enabled: true<br>
            usesPlasmaTheme: false<br>
<br>
            source: decoration<br>
<br>
        }<br>
<br>
    }<br>
</span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
</div></div></blockquote></div><br></div></div>