<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127651/">https://git.reviewboard.kde.org/r/127651/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On Юни 24th, 2016, 5:52 след обяд EEST, <b>Andrey Bondrov</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done:
1. KF 5.23.0
2. Plasma 5.6.5
3. MiminizeAll applet latest snapshot from github (May 31, 2016)
4. ShowDesktop applet from Plasma 5.6.5.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added MinimizeAll abd ShowDesktop applets to panel and assigned different keyboard shortcuts to them. ShowDesktop works via shortcut while MinimizeAll doesn't.</p></pre>
 </blockquote>




 <p>On Юли 21st, 2016, 11:44 преди обяд EEST, <b>Kai Uwe Broulik</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is because it doesn't handle Plasmoid.onActivated - this signal is emitted when the user presses the assigned global shortcut.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plasmoid.onActivated: activate()</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">should do the trick</p></pre>
 </blockquote>





 <p>On Юли 21st, 2016, 12:04 след обяд EEST, <b>Andrey Bondrov</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anthony, can you please add this to the code review (but first check if it works)?</p></pre>
 </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not handle because Kwin has own keyboard shortcut for hat, it will be confused, about me.
http://oi66.tinypic.com/i3b778.jpg</p></pre>
<br />










<p>- Anthony</p>


<br />
<p>On Април 28th, 2016, 11:11 преди обяд EEST, Anthony Fieroni wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian Kügler.</div>
<div>By Anthony Fieroni.</div>


<p style="color: grey;"><i>Updated Април 28, 2016, 11:11 преди обяд</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">^^</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/CMakeLists.txt <span style="color: grey">(e591c81)</span></li>

 <li>applets/minimizeall/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/plugin/minimizeall.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/plugin/minimizeall.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/plugin/minimizeallplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/plugin/minimizeallplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/minimizeall/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127651/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png">Screenshot_20160428_110625.png</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>