<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128400/">https://git.reviewboard.kde.org/r/128400/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2016, 11:21 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Visual aspects should stay under the theme's control. Therefore, from the usability perspective, there should be no user option, instead the look & feel theme should be able to control the icon size.</p></pre>
</blockquote>
<p>On July 8th, 2016, 6:36 p.m. UTC, <b>John Salatas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think that currently the theme controls it. It scales to follow the panel's size up to a certain size which is hardcoded: units.iconSizes.medium</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why units.iconSizes.medium and not units.iconSizes.smallMedium? Is this a design decision or just a random pickup? :\</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What I'm proposing here is let the user choose instead of having an arbitrary maximum size hardcoded. :\</p></pre>
</blockquote>
<p>On July 8th, 2016, 6:54 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i do think smallmedium would be a better default.
in order to do as Thomas suggests, it can have the configuration value, but not exposed from the config dialog (and yeah, defaulting to smallmedium).
then, look and feel packages can contain default setups for applets, it would be that one that make it theme-controlled.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, i would save in the config smallmedium/medium etc, instead of a pixel size value, in order to still survive DPI changes, screen migration etc.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK. I just updated the diff file. The system tray now has the iconSize option which is not exposed from the config dialog. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Look and feel packages can set this value according to the documentation at https://userbase.kde.org/KDE_System_Administration/PlasmaTwoDesktopScripting#Default_applets_config_from_Look_and_Feel_packages</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is by creating a file name org.kde.plasma.private.systemtray.js in the plasmoidsetupscripts subfolder of the Look and Feel package with the following contents</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">applet.currentConfigGroup = new Array("General");
applet.writeConfig("iconSize", 1);
applet.reloadConfig();
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course a user can still modify this value by manually editing his ~/.config/plasma-org.kde.plasma.desktop-appletsrc</p></pre>
<br />
<p>- John</p>
<br />
<p>On July 8th, 2016, 8:56 a.m. UTC, John Salatas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By John Salatas.</div>
<p style="color: grey;"><i>Updated July 8, 2016, 8:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Configuration option for system tray's icon sizes in order to be handled by look & feel themes/packages.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested in KDE Neon Developer Stable (as of July 7, 2016)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/code/IconSizeTools.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemtray/package/contents/config/main.xml <span style="color: grey">(65a7029)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(a66ea69)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128400/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>