<table><tr><td style="">davidedmundson added inline comments.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2089" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2089#inline-8321" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvgItem</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">id : listItemSvg</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You're using the margins from this frame, but you're not even rendering this frame anywhere?<br />
Using the margins from something we're not rendering doesn't make really make sense semantically.</p>
<p style="padding: 0; margin: 8px;">Then later we later use the left/right margins from the highlight which makes even less sense. No-one else does that.</p>
<p style="padding: 0; margin: 8px;">We have a consistency problem with list view delegates over Plasma generally, so I this probably isn't any worse, but it's not right.</p>
<p style="padding: 0; margin: 8px;">There is a PlasmaComponents.ListItem which does a fairly good job of handling some of this vaguely consistently. Though that's currently only used by 4 things.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2089#inline-8316" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span style="color: #004012"><span class="bright">print</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">models</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">tasks</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">height:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">itemHeight</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">width:</span> <span style="color: #004012">windowListView</span><span class="p">.</span><span style="color: #004012">overflowing</span> <span style="color: #aa2211">?</span> <span style="color: #004012">ListView</span><span class="p">.</span><span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">-</span> <span style="color: #aa4000">units.smallSpacing :</span> <span style="color: #004012">ListView</span><span class="p">.</span><span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not tested, but will this work with RTL?</p>
<p style="padding: 0; margin: 8px;">Note if not, you just need an anchors.left: parent.left and it will</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2089#inline-8318" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:203</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">text:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Actions"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">anchors.<span class="bright">c</span>enter<span class="bright">In</span>:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"> </span><span style="color: #aa4000">anchors.<span class="bright">verticalC</span>enter:</span> <span style="color: #004012">parent<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">verticalCenter</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it's better to do</p>
<p style="padding: 0; margin: 8px;">height: parent.height<br />
you already have the centering of the text in the text alignment</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2089" rel="noreferrer">https://phabricator.kde.org/D2089</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>davidedmundson, broulik, plasma-devel, jensreuterberg, abetts, sebas<br /></div>