<table><tr><td style="">graesslin added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1989" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good now and I think we can look into the next steps: rendering the KWin instance you launch. The launched KWin instance connects to your Wayland server, binds to the Shell and will create a ShellSurface. That you will get through a signal on m_shell - compare wayland_server.cpp:148. I would as a next step try to hook into this and see whether the surface gets created. Once you have that you can look into rendering it.</p>
<p>For that the ShellSurfaceInterface is connected to a SurfaceInterface. The rendering happens on the SurfaceInterface. There's a damaged signal which you should use to trigger a repaint of your QQuickItem. When rendering you can access the buffer on the SurfaceInterface. If KWin uses KWIN_COMPOSE=Q you can access the buffer as a QImage and just render it. Pretty straight forward - hopefully. But first try to see whether you get the ShellSurface created. If not we need to look into what goes wrong.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1989#inline-8208" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.cpp:73</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">m_kwinWaylandProcess</span><span style="color: #aa2211">-></span><span class="n">setProcessChannelMode</span><span class="p">(</span><span class="n">QProcess</span><span style="color: #aa2211">::</span><span class="n">ForwardedChannels</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QProcessEnvironment</span> <span class="n">environment</span> <span style="color: #aa2211">=</span> <span class="n">QProcessEnvironment</span><span style="color: #aa2211">::</span><span class="n">systemEnvironment</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">environment</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"WAYLAND_SOCKET"</span><span class="p">),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromUtf8</span><span class="p">(</span><span class="n">QByteArray</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">socket</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There's one more env variable we should pass to the environment:<br />
KWIN_COMPOSE=Q</p>
<p style="padding: 0; margin: 8px;">In the long run we won't need that, but for the moment I think it makes our life easier. It forces the compositor to use QPainter instead of OpenGL, thus integrating the rendering will be way easier.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1989#inline-8206" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.cpp:77-79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QStringList</span> <span class="n">arguments</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">arguments</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"--xwayland"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">arguments</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"--socket"</span> <span style="color: #aa2211"><<</span> <span class="n">m_socketName</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please parse the arguments as:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QStringList arguments{QStringLiteral("--xwayland"), QStringLiteral("--socket"), m_socketName};</pre></div>
<p style="padding: 0; margin: 8px;">That way the list can be constructed in one go and not need to be appended multiple times.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1989#inline-8207" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.cpp:80</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">arguments</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"--socket"</span> <span style="color: #aa2211"><<</span> <span class="n">m_socketName</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">m_kwinWaylandProcess</span><span style="color: #aa2211">-></span><span class="n">start</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="n">KWIN_WAYLAND_BINARY_PATH</span><span class="p">),</span> <span class="n">arguments</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think we need to pass a few more arguments:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">--width</li>
<li class="remarkup-list-item">--height</li>
</ul>
<p style="padding: 0; margin: 8px;">with the values set to the size of this argument.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1989#inline-8209" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.h:61-62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">Q_INVOKABLE</span> <span style="color: #aa4000">void</span> <span class="n">start</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">Q_INVOKABLE</span> <span style="color: #aa4000">void</span> <span style="color: #004012">stop</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I still do not really see the point in those two methods. The start could be handled by implementing the componentComplete method. The stop by calling that from the destructor.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1989" rel="noreferrer">https://phabricator.kde.org/D1989</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>bdhruve, bshah, Plasma on Wayland, graesslin<br /><strong>Cc: </strong>bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas<br /></div>