<table><tr><td style="">broulik added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1976" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Do you actually cache the downloaded image somewhere on disk? I wouldn't want every startup of plasma download the image. Also, does it check for mobile internet being used instead of Wifi, looks like we need a NM dataengine.</p>
<p><a href="https://phabricator.kde.org/p/graesslin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@graesslin</a> Perhaps we need to re-introduce the X-Required-Permission stuff so a wallpaper can specify it needs internet and can then be filtered out from the lock screen config?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7676" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">model:</span> <span class="p">[</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">{</span> <span style="color: #766510">"label"</span><span style="color: #aa2211">:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Scaled and Cropped"</span><span class="p">),</span> <span style="color: #766510">"fillMode"</span><span style="color: #aa2211">:</span> <span style="color: #004012">Image</span><span class="p">.</span><span style="color: #004012">PreserveAspectCrop</span> <span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">{</span> <span style="color: #766510">"label"</span><span style="color: #aa2211">:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Scaled"</span><span class="p">),</span> <span style="color: #766510">"fillMode"</span><span style="color: #aa2211">:</span> <span style="color: #004012">Image</span><span class="p">.</span><span style="color: #004012">Stretch</span> <span class="p">},</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Those quotes are unneccessary, label: "foo" is enough</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7677" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">Component.onCompleted:</span> <span class="p">{</span> <span style="color: #004012">readSizePosition</span><span class="p">();</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">onCurrentIndexChanged:</span> <span class="p">{</span> <span style="color: #004012">writeSizePosition</span><span class="p">();</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Those {} are unneccessary, Component.onCompleted: readSizePosition()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7678" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa4000">in</span> <span style="color: #004012">model</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">model</span><span class="p">[</span><span style="color: #004012">i</span><span class="p">][</span><span style="color: #766510">"fillMode"</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #004012">wallpaper</span><span class="p">.</span><span style="color: #004012">configuration</span><span class="p">.</span><span style="color: #004012">FillMode</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">sizePositionCombo</span><span class="p">.</span><span style="color: #004012">currentIndex</span> <span style="color: #aa2211">=</span> <span style="color: #004012">i</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">model[i].fillMode ===</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7679" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:211</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">nameFilters:</span> <span class="p">[</span> <span style="color: #766510">"Image files (*.jpg *.jpe *.jpeg *.png *.bmp *.svg *.svgz)"</span> <span class="p">]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">selectExisting:</span> <span style="color: #000a65">true</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can we do mime filters instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7680" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:213-214</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">selectExisting:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">selectFolder:</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">selectMultiple:</span> <span style="color: #000a65">false</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I suppose those are the default values and don't need to explicitly mentioning?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7682" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">function</span> <span style="color: #004012">evalEnabledSources</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">enabledSources</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you make this more declarative, ie.?</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">property var enabledSources: {
// the stuff of this function
}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7681" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">function</span> <span style="color: #004012">evalEnabledSources</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">enabledSources</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa4000">in</span> <span style="color: #004012">allSources</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Urgh</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEPLASMAADDONS Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1976" rel="noreferrer">https://phabricator.kde.org/D1976</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>bgupta, sebas, Plasma<br /><strong>Cc: </strong>broulik, garg, sebas, graesslin, davidedmundson, plasma-devel, Plasma, jensreuterberg<br /></div>