<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128136/">https://git.reviewboard.kde.org/r/128136/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 17th, 2016, 5:32 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still think that the applets need a completely different layout in order to really be useful in panels (who would really want to use a whole panel just to show CPU load?), but that's probably for another patch.
The changes themselves look fine!</p></pre>
</blockquote>
<p>On June 17th, 2016, 8:44 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't understand the first sentence. there is the cup applet with an diagramm mode (and some other diagramm mode plasmoids) and the system load plasmoid where you can see what happens now. In general the diagramm mode is for me more importend than the what's happen now. From the visual design I like the diagrammms but I'm not happy to show the graph grid (0-line) this would be usefull when you can have negative values but here it is not needed. but however we will see what a future request will bring.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">waiting for a ship it from a developer.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In Plasma 4, the system monitor plasmoids were far more narrow.
If you use e.g. the CPU monitor Plasmoid in Plasma 5, it occupies almost your whole panel by default. Are these graphs really important enough for anybody to occupy a whole panel with them?</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On June 16th, 2016, 12:14 p.m. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated June 16, 2016, 12:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">change the minimum size and the min width in the panel</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">speedLabels are now right align to the label cause you show the number which is drown on the right part of the diagramm </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">round to 14 % instead of 14,14 % for cpu load</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">still missing:
a. hide the heading if the desktop widget has to less space for the rows
b. better friendlyName for ram, network
c. remove the gray line from the chart (0-line) at least when the applet was shown on the panel
d. don't show 0 KB/s or 0 B, ...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">shedule
thanks for your review
if you know how I can fix one of the missing things, let me know
tiny improvements when missing stuff is finished.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on the desktop and the panel</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemmonitor/common/contents/ui/Applet.qml <span style="color: grey">(fffd8e0)</span></li>
<li>applets/systemmonitor/common/contents/ui/DoublePlotter.qml <span style="color: grey">(738ffbc)</span></li>
<li>applets/systemmonitor/common/contents/ui/SinglePlotter.qml <span style="color: grey">(987fd2c)</span></li>
<li>applets/systemmonitor/cpu/contents/ui/cpu.qml <span style="color: grey">(4ebbf92)</span></li>
<li>applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml <span style="color: grey">(994336f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128136/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/4fecb3bc-d540-4358-af1d-342c77b9cfa3__Screenshot_20160616_111131.png">screenshot of the result</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>