<table><tr><td style="">hein accepted this revision.<br />hein added a comment.<br />This revision is now accepted and ready to land.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1865" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Since I'm only asking for comment changes I'm accepting it code-wise :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1865#inline-7228" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tasksmodel.cpp:744</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">filterIndex</span><span class="p">.</span><span class="n">data</span><span class="p">(</span><span class="n">AbstractTasksModel</span><span style="color: #aa2211">::</span><span class="n">IsLauncher</span><span class="p">).</span><span class="n">toBool</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #74777d">// TODO: it would be much faster if we didn't ask for a URL with serialized PNG data in it, just to discard it a few lines below</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span style="color: #aa2211">&</span><span class="n">launcherUrl</span> <span style="color: #aa2211">=</span> <span class="n">filterIndex</span><span class="p">.</span><span class="n">data</span><span class="p">(</span><span class="n">AbstractTasksModel</span><span style="color: #aa2211">::</span><span class="n">LauncherUrl</span><span class="p">).</span><span class="n">toUrl</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">(Very) pedantic: "It" should be uppercase and the sentence end in a period.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1865#inline-7227" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tasksmodel.cpp:1324</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">filteredIndex</span><span class="p">.</span><span class="n">data</span><span class="p">(</span><span class="n">AbstractTasksModel</span><span style="color: #aa2211">::</span><span class="n">LauncherUrl</span><span class="p">).</span><span class="n">toUrl</span><span class="p">(),</span> <span class="n">IgnoreQueryItems</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">emit</span></span><span class="bright"> </span><span class="n"><span class="bright">launcherCountC</span>hange<span class="bright">d</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span style="color: #74777d"><span class="bright">// Not sure why this is here. We're filtering, not handling a c</span>hange<span class="bright">.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">invokeMethod</span><span class="p">(</span><span style="color: #aa4000">const_cast</span><span style="color: #aa2211"><</span><span class="n">TasksModel</span> <span style="color: #aa2211">*></span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">),</span> <span style="color: #766510">"updateLauncherCount"</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">QueuedConnection</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If filterAcceptsRow() decides to filter out a launcher task, the count might have changed. Of course it would also be possible to do this outside of filtering, but ... can you drop this comment for now?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1865" rel="noreferrer">https://phabricator.kde.org/D1865</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>dfaure, hein<br /><strong>Cc: </strong>broulik, plasma-devel, jensreuterberg, sebas<br /></div>