<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128181/">https://git.reviewboard.kde.org/r/128181/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also the two were slightly out of sync leading to some connections not
being in each constructor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">previous code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FIRST CTOR ONLY (normal mode)
connect(applet(), &Plasma::Applet::contextualActionsAboutToShow,
this, &AppletInterface::contextualActionsAboutToShow);</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:activated</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:activated</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:expandedChanged</span><span style="color: #666666">,</span> <span style="color: #BC7A00">[</span><span style="color: #666666">=</span><span style="color: #BC7A00">]</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">bool</span> <span style="color: #008000; font-weight: bold">expanded</span><span style="color: #666666">)</span> {
<span style="color: #666666">//</span>if <span style="color: #008000; font-weight: bold">both</span> compactRepresentationItem and fullRepresentationItem exist<span style="color: #666666">,</span>
<span style="color: #666666">//</span>the applet is in a popup
if (<span style="color: #008000; font-weight: bold">expanded</span>) <span style="border: 1px solid #FF0000">{</span>
if (compactRepresentationItem() <span style="color: #666666">&&</span> fullRepresentationItem() <span style="color: #666666">&&</span>
fullRepresentationItem()<span style="color: #666666">-></span>window() <span style="color: #666666">&&</span> compactRepresentationItem()<span style="color: #666666">-></span>window() <span style="color: #666666">&&</span>
fullRepresentationItem()<span style="color: #666666">-></span>window() <span style="color: #666666">!=</span> compactRepresentationItem()<span style="color: #666666">-></span>window() <span style="color: #666666">&&</span>
fullRepresentationItem()<span style="color: #666666">-></span>parentItem()) <span style="border: 1px solid #FF0000">{</span>
fullRepresentationItem()<span style="color: #666666">-></span>parentItem()<span style="color: #666666">-></span>installEventFilter(this);
} <span style="color: #008000; font-weight: bold">else</span> <span style="color: #008000; font-weight: bold">if</span> <span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">fullRepresentationItem</span><span style="color: #666666">()</span> <span style="color: #666666">&&</span> <span style="color: #008000; font-weight: bold">fullRepresentationItem</span><span style="color: #666666">()</span><span style="color: #008000; font-weight: bold">-</span><span style="color: #666666">></span><span style="color: #008000; font-weight: bold">parentItem</span><span style="color: #666666">())</span> {
fullRepresentationItem()<span style="color: #666666">-></span>parentItem()<span style="color: #666666">-></span>removeEventFilter(this);
}
<span style="border: 1px solid #FF0000">}</span>
<span style="border: 1px solid #FF0000">}</span><span style="color: #666666">);</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SECOND CTOR ONLY (special comic applet path)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">connect(applet(), &Plasma::Applet::configurationRequiredChanged,
this, [this](bool needsConfig, const QString &reason) {
emit configurationRequiredChanged();
emit configurationRequiredReasonChanged();
});
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">DUPLICATED:
qmlRegisterType<QAction>();</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:configNeedsSaving</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:configNeedsSaving</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:immutabilityChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:immutabilityChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:userConfiguringChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:userConfiguringChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:statusChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:statusChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:destroyedChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:destroyedChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:titleChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:titleChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:iconChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:iconChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">Plasma</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Applet</span><span style="color: #666666">:</span><span style="color: #AA22FF">:busyChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:busyChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">appletScript</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">DeclarativeAppletScript</span><span style="color: #666666">:</span><span style="color: #AA22FF">:formFactorChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:formFactorChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">appletScript</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">DeclarativeAppletScript</span><span style="color: #666666">:</span><span style="color: #AA22FF">:locationChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:locationChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">connect</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">appletScript</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">DeclarativeAppletScript</span><span style="color: #666666">:</span><span style="color: #AA22FF">:contextChanged</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">this</span><span style="color: #666666">,</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">AppletInterface</span><span style="color: #666666">:</span><span style="color: #AA22FF">:contextChanged</span><span style="color: #666666">);</span>
<span style="color: #008000; font-weight: bold">if</span> <span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">applet</span><span style="color: #666666">()</span><span style="color: #008000; font-weight: bold">-</span><span style="color: #666666">></span><span style="color: #008000; font-weight: bold">containment</span><span style="color: #666666">())</span> {
connect(applet()<span style="color: #666666">-></span>containment()<span style="color: #666666">,</span> <span style="color: #666666">&</span>Plasma<span style="color: #666666">::</span>Containment<span style="color: #666666">::</span>screenChanged<span style="color: #666666">,</span>
this<span style="color: #666666">,</span> <span style="color: #666666">&</span>ContainmentInterface<span style="color: #666666">::</span>screenChanged);
}
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scriptengines/qml/plasmoid/appletinterface.h <span style="color: grey">(6a64594cd53cecfbc99ad7562706e1a78d60c138)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: grey">(df2d642445bdcc81d7fed463cb38c337380ea25b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128181/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>