<table><tr><td style="">mak added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1844" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1844#34142" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D1844#34142</a>, <a href="https://phabricator.kde.org/p/sebas/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@sebas</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Should also have a screenshot?</p></div>
</blockquote>
<p>Normally I would say "yes", but since this is a so-called generic component, which means that it will be possible to search for it with cli tools and install it easily e.g. via "appstreamcli install <id>`, but it will generally not be visible in tools like Discover.<br />
This is because installing a complete DE is usually seen to be a bad idea.</p>
<p>So, adding screenshots won't hurt, but they won't be as visible as type=desktop component ones.<br />
Btw, having a generic name of Plasma means one can write metainfo files for Plasmoids (which would sett "<extends>org.kde.plasmashell</>" in their metainfo file), meaning Plasma would be able to search for Plasmoids in a distro-agnostic way, so this is a great addition.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1844#inline-7130" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:158</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">endif()
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">install( FILES "${CMAKE_CURRENT_BINARY_DIR}/plasma-desktop.metainfo.xml" DESTINATION ${SHARE_INSTALL_PREFIX}/appdata/
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should be <tt style="background: #ebebeb; font-size: 13px;">${SHARE_INSTALL_PREFIX}/metainfo/</tt>, the "appdata" path is the legacy location.<br />
Or simply use the e-c-m variable (which still needs to be updated to point to /metainfo at a later time).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1844#inline-7127" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasma-desktop.metainfo.xml:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #00702a"><component></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><id></span>kde-plasma-desktop<span style="color: #00702a"></id></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><project_license></span>GPL-2.0+<span style="color: #00702a"></project_license></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should ideally be a reverse-domain-name, to fit the general style of AppStream unique IDs.<br />
So something like "org.kde.plasmashell" or "org.kde.plasma-desktop".<br />
See <a href="https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic" class="remarkup-link" target="_blank" rel="noreferrer">https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1844#inline-7126" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bshah</span> wrote in <span style="color: #4b4d51; font-weight: bold;">plasma-desktop.metainfo.xml:11</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This is wrong, no? there is no plasma-desktop binary anymore? or you mean package name?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Jup, the binary name would be plasmashell. But you could omit this data block entirely, unless you want people to be able to search for the AppStream component when they know the binary name.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1844" rel="noreferrer">https://phabricator.kde.org/D1844</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>jriddell, Visual design and promo, sebas, Plasma, mak<br /><strong>Cc: </strong>bshah, sebas, plasma-devel<br /></div>