<table><tr><td style="">graesslin created this revision.<br />graesslin added reviewers: Plasma on Wayland, KWin.<br />Restricted Application added subscribers: kwin, plasma-devel.<br />Restricted Application added projects: Plasma on Wayland, KWin.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1803" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The implementation was broken as it transformed the QRects into QRegions,<br />
subtracted the geometries and took the bounding rect again. In several<br />
setups this could result in the strut getting ignored.</p>
<p>This change improves the calculation of the struts by creating a QMargin<br />
which describes the area which needs to be subtracted from a screen rect.<br />
The QMargin is only adjusted for the edge the window borders. We can<br />
assume that a window with a strut needs to border a screen on Wayland.</p>
<p>With this change we are also able to support panels between screens.<br />
On Wayland a panel placed on the right of a left screen affects the<br />
maximization area of the left screen, but does not affect the overall<br />
workarea.</p>
<p>CCBUG: 167852</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>wayland-struts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1803" rel="noreferrer">https://phabricator.kde.org/D1803</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/wayland/struts_test.cpp<br />
geometry.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma on Wayland, KWin<br /><strong>Cc: </strong>plasma-devel, kwin, sebas<br /></div>