<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128108/">https://git.reviewboard.kde.org/r/128108/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pretty good for your first QML patch :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But there are a few issues that need to be fixed first and some which should be improved.
See the list of "Issues" below the screenshots at the "Reviews" page (which is the default view of this review request at https://git.reviewboard.kde.org/r/128108/)</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128108/diff/3/?file=467956#file467956line35" style="color: black; font-weight: bold; text-decoration: underline;">applets/weather/package/contents/ui/TopPanel.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">width:</span> <span class="nx">height</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">width:</span> <span class="nx"><span class="hl">parent</span></span><span class="p"><span class="hl">.</span></span><span class="nx">height</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This change is not needed, and might be slightly more expensive, at least breaks the code pattern I saw in Plasma, so please revert it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Binding "width" to "height" of the same object is fine. And "height" is bound to "parent.height", so the code already should behave as you want it. If not, there would be a bug elsewhere, please report.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128108/diff/3/?file=467957#file467957line39" style="color: black; font-weight: bold; text-decoration: underline;">applets/weather/package/contents/ui/WeatherListView.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">color:</span> <span class="nx">Qt</span><span class="p">.</span><span class="nx">rgba</span><span class="p">(</span><span class="nx">theme</span><span class="p">.</span><span class="nx">textColor</span><span class="p">.</span><span class="nx">r</span><span class="p">,</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">textColor</span><span class="p">.</span><span class="nx">g</span><span class="p">,</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">textColor</span><span class="p">.</span><span class="nx">b</span><span class="p">,</span> <span class="p"><span class="hl">((</span></span><span class="nx"><span class="hl">index</span></span><span class="o"><span class="hl">+</span></span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">)</span></span><span class="o"><span class="hl">/</span></span><span class="nx"><span class="hl">repeater</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">count</span></span><span class="p"><span class="hl">)</span></span><span class="o"><span class="hl">*</span></span><span class="mf"><span class="hl">0.3</span></span><span class="p"><span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">color:</span> <span class="nx">Qt</span><span class="p">.</span><span class="nx">rgba</span><span class="p">(</span><span class="nx">theme</span><span class="p">.</span><span class="nx">textColor</span><span class="p">.</span><span class="nx">r</span><span class="p">,</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">textColor</span><span class="p">.</span><span class="nx">g</span><span class="p">,</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">textColor</span><span class="p">.</span><span class="nx">b</span><span class="p">,</span> <span class="mi"><span class="hl">0</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Instead of making the rectangle transparent, turn it into a normal undrawn Item, by removing the properties "radius" and "color" and changing the type to "Item" instead of "Rectangle", like:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> Item {
id: rect
height: root.rowHeight
width: root.width
Loader {
[...]
</pre></div>
</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128108/diff/3/?file=467958#file467958line117" style="color: black; font-weight: bold; text-decoration: underline;">applets/weather/package/contents/ui/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">top</span>Margin:</span> <span class="nx">units</span><span class="p">.</span><span class="nx"><span class="hl">large</span>Spacing</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">bottom</span>Margin:</span> <span class="nx">units</span><span class="p">.</span><span class="nx">Spacing</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">bottomMargin:</span> <span class="nx">units</span><span class="p">.</span><span class="nx">largeSpacing</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is still "units.Spacing" set for the bottomMargin, which will yield 0. So if you want to set 0 here for both margins, best set that explicitely (not sure what the default is):</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> topMargin: 0
bottomMargin: 0
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, having both top and bottom margin 0 now looks a little bit dense to me. But well, if you prefer that, okay.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128108/diff/3/?file=467958#file467958line155" style="color: black; font-weight: bold; text-decoration: underline;">applets/weather/package/contents/ui/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">155</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">linkColor <span class="hl">:</span></span><span class="hl"> </span><span class="nx"><span class="hl">c</span>olor</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">154</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">linkColor<span class="hl">:</span></span><span class="hl"> </span><span class="nx"><span class="hl">theme</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">textC</span>olor</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No need to change this, "color" is already bound to "theme.textColor" due to this being a PlasmaComponents.Label</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128108/diff/3/?file=467958#file467958line156" style="color: black; font-weight: bold; text-decoration: underline;">applets/weather/package/contents/ui/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">156</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">textFormat:</span> <span class="nx">Text</span><span class="p">.</span><span class="nx">StyledText</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">155</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">opacity:</span> <span class="mf">0.6</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please do not delete "textFormat: Text.StyledText", just add "opacity: 0.6".</p></pre>
</div>
</div>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On June 7th, 2016, 11:46 a.m. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Friedrich W. H. Kossebau.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated June 7, 2016, 11:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the scaling work now better and the pading between the single lines can be smaler (If you make the applet higher you can also have the old line spacing)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's my first qml change, so ...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on my todo, I'd like to change the powerd by weather.com text color so a secondary gray (bring it a bit more to the background), but I don't know how.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with breeze and breeze dark color scheme on two different pc's. the icons are breeze weather icons (master)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/weather/package/contents/ui/TopPanel.qml <span style="color: grey">(1821f16)</span></li>
<li>applets/weather/package/contents/ui/WeatherListView.qml <span style="color: grey">(c7b331e)</span></li>
<li>applets/weather/package/contents/ui/main.qml <span style="color: grey">(d490728)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128108/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png">screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png">I hope I had fixed all open issues. I now have only one open issue I could change the linkColor but I can't change the color when there is no link like in noaa</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>