<table><tr><td style="">graesslin added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1770" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>can you explain why it should be configurable?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1770#inline-6932" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">osd.cpp:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">,</span> <span class="n">m_osdPath</span><span class="p">(</span><span class="n">corona</span><span style="color: #aa2211">-></span><span class="n">lookAndFeelPackage</span><span class="p">().</span><span class="n">filePath</span><span class="p">(</span><span style="color: #766510">"osdmainscript"</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">,</span> <span class="n">m_osdConfig</span><span class="p">(</span><span class="n">KConfigGroup</span><span class="p">(</span><span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"plasmarc"</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"OSD"</span><span class="p">)))</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">sharing a lesson learned from KWin: if you dependency inject the KSharedConfig you get two advantages:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">No stringly-typed names like plasmarc</li>
<li class="remarkup-list-item">the class is easier to test as in a unit test you can inject a dummy KSharedConfig exactly with the key/values as one needs.</li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1770" rel="noreferrer">https://phabricator.kde.org/D1770</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>graesslin, plasma-devel, sebas<br /></div>