<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1735" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>...Initial support for peripheral battery notifications</p>
<p>When the battery in a non-power supply battery drops below 10% it emits a notification.</p>
<p>Missing:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Don't notify when battery is not present (otherwise will have 0%)</li>
<li class="remarkup-list-item">Notify when new device is plugged in</li>
<li class="remarkup-list-item">Messages for other batteries than mouse and keyboard(?)</li>
</ul>
<p>It does not yet chec</p>
<p>Initial support for peripheral battery notifications</p>
<p>When the battery in a non-power supply battery drops below 10% it emits a notification.</p>
<p>Missing:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Don't notify when battery is not present (otherwise will have 0%)</li>
<li class="remarkup-list-item">Notify when new device is plugged in</li>
<li class="remarkup-list-item">Messages for other batteries than mouse and keyboard(?)</li>
</ul>
<p>It does not yet chec</p>
<p>[Profiles KCM] Add spinbox for changing the low peripheral battery threshold</p>
<p>Notify about low peripheral devices on startup similar to what we do with the laptop battery</p>
<p>Improve wording of notifications</p>
<p>Always show the name of the device. It might by cryptic, so we'll have to<br />
monitor how that turns out. In any case the affected device type (mouse, keyboard, ...)<br />
is indicated by both the icon and the notification body text.</p>
<p>Remove m_batteriesUdi QStringList</p>
<p>We can just use the keys of m_batteriesPercent instead like<br />
we already do for peripheral devices</p>
<p>Merge branch 'broulik/notifyPeripherals' of git://anongit.kde.org/powerdevil into broulik/notifyPeripherals</p>
<p>Notify about low peripherals when plugging them in</p>
<p>Unfortunately my mouse reports info only periodically, so when plugging<br />
it in it is always "not present" and 0%, so it doesn't show for me.<br />
Also, when the device is really empty (so won't work) it won't show<br />
anything either because it won't be "present". Oh, well...</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>So far I have only tested this with my mouse on a desktop computer,<br />
starting kded5 brings the notification. Needs more testing with a laptop so it<br />
didn't break the default battery handling</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPOWERDEVIL Powerdevil</div></div></div><br /><div><strong>BRANCH</strong><div><div>broulik/notifyPeripherals</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1735" rel="noreferrer">https://phabricator.kde.org/D1735</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>PowerDevilSettings.kcfg<br />
daemon/powerdevilcore.cpp<br />
daemon/powerdevilcore.h<br />
kcmodule/global/GeneralPage.cpp<br />
kcmodule/global/generalPage.ui<br />
powerdevil.notifyrc</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, sebas<br /></div>