<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128073/">https://git.reviewboard.kde.org/r/128073/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Speaking with the maintainer's hat on: I don't want this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here are the reasons:
- We are short on manpower, adding a build option makes this worse as we now have to maintain different versions of the build
- It's not going to be autotested on KDE CI
- I don't have the time to tell users that they have to rebuild libkscreen with wayland enabled to fix their systems
- I can't guarantee that changes we make in the future won't require wayland, and I'm not willing to invest time into making sure it still builds in both configurations</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I understand that for some, it's important to have no wayland deps (be these reasons valid or not), but for us it's causing more work and for the sake of our users, I'm making the call that we concentrate on bugs our users report, not on making our builds more complex, because that would achieve the opposite.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, NAK.</p></pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On June 1st, 2016, 8:10 a.m. UTC, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and Sebastian Kügler.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated June 1, 2016, 8:10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Look for KF5Wayland as optional package, not building all the Wayland-related code (backend, additions to tests, DPMS support in kscreen-doctor) if it is not available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This allows libkscreen to build again on platforms without Wayland, such as non-Linux or old Linux distros.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9c834d9500fa0b89764516464bd58e835671977b)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(2c8ee3d2021b1222072d6a1faafaff1b336d27e3)</span></li>
<li>backends/CMakeLists.txt <span style="color: grey">(3563e138454edcc0c874237745123b09077d067c)</span></li>
<li>src/doctor/CMakeLists.txt <span style="color: grey">(7294d88af127a6604bc7e48e16342c93f152de8c)</span></li>
<li>src/doctor/doctor.cpp <span style="color: grey">(a156f006212e63c155a6f643929d0a5880275731)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1489d21383e13cd1431a81d48b4a272c28302041)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128073/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>