<div>graesslin added inline comments.</div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1638#inline-6585" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xuetianweng</span> wrote in <span style="color: #4b4d51; font-weight: bold;">main_wayland.cpp:449</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the session I wonder if it will be inherit by the whole desktop session.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't understand the concern. The QT_IM_MODULE env variable set here in the code only affects KWin. It is not passed to any other process.</p>
<p style="padding: 0; margin: 8px;">Setting QT_IM_MODULE env variables will still overwrite everything - except in KWin where the variable is pointless. So nothing changes except by default KWin can now offer a virtual keyboard.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>virtual-keyboard</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1638" rel="noreferrer">https://phabricator.kde.org/D1638</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma, sebas<br /><strong>Cc: </strong>xuetianweng, sebas, mart, broulik, plasma-devel<br /></div>