<div>xuetianweng added inline comments.</div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1638#inline-6500" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main_wayland.cpp:449</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">qunsetenv</span><span class="p">(</span><span style="color: #766510">"QT_DEVICE_PIXEL_RATIO"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="n">q<span class="bright">unse</span>tenv</span><span class="p">(</span><span style="color: #766510">"QT_IM_MODULE"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">q<span class="bright">pu</span>tenv</span><span class="p">(</span><span style="color: #766510">"QT_IM_MODULE<span class="bright">"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"qtvirtualkeyboard</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">qputenv</span><span class="p">(</span><span style="color: #766510">"QSG_RENDER_LOOP"</span><span class="p">,</span> <span style="color: #766510">"basic"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt.</p>

<p style="padding: 0; margin: 8px;">IMHO for wayland there should be  a wayland specific im module that talk to input method via wl_text.</p>

<p style="padding: 0; margin: 8px;">And X11 app should use a different QT_IM_MODULE.</p>

<p style="padding: 0; margin: 8px;">FYI: <a href="https://fcitx-im.org/wiki/Input_method_related_environment_variables" class="remarkup-link" target="_blank" rel="noreferrer">https://fcitx-im.org/wiki/Input_method_related_environment_variables</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>virtual-keyboard</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1638" rel="noreferrer">https://phabricator.kde.org/D1638</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma, sebas<br /><strong>Cc: </strong>xuetianweng, sebas, mart, broulik, plasma-devel<br /></div>