<div>bshah requested changes to this revision.<br />
bshah added a reviewer: bshah.<br />
bshah added inline comments.<br />
This revision now requires changes to proceed.</div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1672#inline-6427" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_fake_input.cpp:328</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #74777d">// without an authentication we shouldn't get the signals</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">m_fakeInput</span><span style="color: #aa2211">-></span><span class="n">requestTouchDown</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span><span class="n">QPointF</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">touchDownSpy</span><span class="p">.</span><span class="n">wait</span><span class="p">(</span><span style="color: #601200">100</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In addition to what <a href="https://phabricator.kde.org/p/graesslin/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> said, one point about coding style,</p>

<p style="padding: 0; margin: 8px;">KWayland is part of KF5 which follows KDE Frameworks 5 <a href="https://techbase.kde.org/Policies/Frameworks_Coding_Style" class="remarkup-link" target="_blank" rel="noreferrer">Coding style guide</a> for its code.</p>

<p style="padding: 0; margin: 8px;">You seem to have used inconsistent coding style for code here and as well other places. Please go over all the code you have added and correct it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1672#inline-6428" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fakeinput_interface.h:128-132</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">touchDownRequested</span><span class="p">(</span><span class="n">quint32</span> <span class="n">id</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QPointF</span> <span style="color: #aa2211">&</span><span class="n">pos</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">touchMotionRequested</span><span class="p">(</span><span class="n">quint32</span> <span class="n">id</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QSizeF</span> <span style="color: #aa2211">&</span><span class="n">delta</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">touchUpRequested</span><span class="p">(</span><span class="n">quint32</span> <span class="n">id</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">touchCancelRequested</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">touchFrameRequested</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Given this will be part of public API,  please add the documentation for this methods like other pointer methods.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWAYLAND KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1672" rel="noreferrer">https://phabricator.kde.org/D1672</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>bdhruve, Plasma, bshah<br /><strong>Cc: </strong>bshah, graesslin, plasma-devel, sebas<br /></div>