<div>apol accepted this revision.<br />
apol added a reviewer: apol.<br />
apol added inline comments.<br />
This revision is now accepted and ready to land.</div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1689#inline-6498" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FontFilter.cpp:169</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="n">QStringList<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">ConstIterator</span></span><span class="bright"> </span><span class="n"><span class="bright">sIt</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">mime<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">patterns</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">constBegin</span></span><span class="bright"></span><span class="p"><span class="bright">()),</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="bright">                           </span><span class="n"><span class="bright">sEnd</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">mime<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">p</span>atterns</span><span class="p">()<span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">constEnd</span></span><span class="bright"></span><span class="p"><span class="bright">());</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright">            </span>    <span class="n">mimes</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                                       
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span style="color: #aa4000">for</span><span class="p">(;</span> <span class="n">sIt</span><span style="color: #aa2211">!=</span><span class="n">sEnd</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">sIt</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span class="n">mimes</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span style="color: #aa2211">*</span><span class="n">sIt</span><span class="p">).</span><span class="n">replace</span><span class="p">(</span><span style="color: #766510">"*."</span><span class="p">,</span> <span style="color: #766510">""</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="n">QStringList<span class="bright"></span></span><span class="bright"> </span><span class="n">mime<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="bright"></span><span class="n"><span class="bright">foreach</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span class="n"><span class="bright">pattern</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">mime<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">globP</span>atterns</span><span class="p">()<span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">mimes<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">append</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">pattern</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">replace</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"*."</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"></span><span class="p"><span class="bright">))</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const QString &</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1689#inline-6499" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FontFilter.cpp:170</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="bright">                           </span><span class="n"><span class="bright">sEnd</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">mime<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">p</span>atterns</span><span class="p">()<span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">constEnd</span></span><span class="bright"></span><span class="p"><span class="bright">());</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright">            </span>    <span class="n">mimes</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                                       
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span style="color: #aa4000">for</span><span class="p">(;</span> <span class="n">sIt</span><span style="color: #aa2211">!=</span><span class="n">sEnd</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">sIt</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span class="n">mimes</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span style="color: #aa2211">*</span><span class="n">sIt</span><span class="p">).</span><span class="n">replace</span><span class="p">(</span><span style="color: #766510">"*."</span><span class="p">,</span> <span style="color: #766510">""</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="bright"></span><span class="n"><span class="bright">foreach</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span class="n"><span class="bright">pattern</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">mime<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">globP</span>atterns</span><span class="p">()<span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">mimes<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">append</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">pattern</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">replace</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"*."</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"></span><span class="p"><span class="bright">))</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">act</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span class="n">mimes</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">""</tt> -> QString() or <tt style="background: #ebebeb; font-size: 13px;">{}</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1689" rel="noreferrer">https://phabricator.kde.org/D1689</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>volkov, Plasma, apol<br /><strong>Cc: </strong>apol, plasma-devel, sebas<br /></div>