<div>graesslin requested changes to this revision.<br />
graesslin added a reviewer: graesslin.<br />
graesslin added inline comments.<br />
This revision now requires changes to proceed.</div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1672#inline-6437" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fakeinput.h:133</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #74777d">     **/</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">requestTouchMotion</span><span class="p">(</span><span class="n">quint32</span> <span class="n">id</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QSizeF</span> <span style="color: #aa2211">&</span><span class="n">delta</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #74777d">/**</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why a delta? In KWin all touchMotion related code takes the new position.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1672#inline-6440" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fake-input.xml:52-68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span style="color: #00702a"><request</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"touch_down"</span> <span style="color: #354bb3">since=</span><span style="color: #766510">"2"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">         <span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"id"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"uint"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">         <span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"x"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"fixed"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">         <span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"y"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"fixed"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span style="color: #00702a"></request></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span style="color: #00702a"><request</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"touch_motion"</span> <span style="color: #354bb3">since=</span><span style="color: #766510">"2"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">          <span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"id"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"uint"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if you have a new enough wayland-scanner installed this should generate errors because it expects documentation. I'm aware that the existing interface is missing documentation, but I think for new code we should make sure that wayland-scanner is happy.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1672#inline-6439" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fakeinput_interface.cpp:194</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">Q_UNUSED</span><span class="p">(</span><span class="n">client</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nitpick: empty line</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1672#inline-6438" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fakeinput_interface.h:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #74777d">     **/</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">void</span> <span style="color: #004012">touchMotionRequested</span><span class="p">(</span><span class="n">quint32</span> <span class="n">id</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QSizeF</span> <span style="color: #aa2211">&</span><span class="n">delta</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #74777d">/**</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWAYLAND KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1672" rel="noreferrer">https://phabricator.kde.org/D1672</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>bdhruve, bshah, Plasma, graesslin<br /><strong>Cc: </strong>bshah, graesslin, plasma-devel, sebas<br /></div>