<div>drosca created this revision.<br />
drosca added reviewers: Plasma, mck182.<br />
Restricted Application added a project: Plasma.<br />
Restricted Application added a subscriber: plasma-devel.</div><br /><div><strong>REVISION SUMMARY</strong><div><p>Changing calendar plugins and holidays regions now enables Apply<br />
button in configuration and correctly saves it.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>It is still needed to restart plasma in order to changes<br />
of holidays regions to take effect.<br />
How to fix it:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Reload the holidays plugin when changing regions</li>
<li class="remarkup-list-item">Watch for plasma_calendar_holiday_regions config file changes in holidays plugin</li>
<li class="remarkup-list-item">Other idea?</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>calendarevents-saving (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1651" rel="noreferrer">https://phabricator.kde.org/D1651</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/digital-clock/package/contents/ui/configCalendar.qml<br />
plasmacalendarintegration/HolidaysConfig.qml<br />
plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>drosca, Plasma, mck182<br /><strong>Cc: </strong>plasma-devel, sebas<br /></div>