<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127963/">https://git.reviewboard.kde.org/r/127963/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 19th, 2016, 5:22 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think the approach here is wrong. Our frameworks are LGPLv2+. If we have files which don't match that we need to either change copyright or remove the files.</p></pre>
</blockquote>
<p>On May 19th, 2016, 5:29 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A check shows that examples/kpart and src/kpart are not built at all. They are dead code and could just be removed. src/plasma/private/packageFOO could easily be wrapped by implementing through the newer KPackage framework. servicejob_p.h might just be incorrectly licensed, history needs to be checked as all other files around it are properly or later.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I just verified for servicejob_p.h, was split out from servicejob.cpp in 89b71cd9f195da51993533f7fc2329ddc08a7de4 of kdelibs</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On May 19th, 2016, 4:37 p.m. CEST, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated May 19, 2016, 4:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.
The list of LGPL-2 only files is:
examples/kpart/containmentshell.cpp
examples/kpart/containmentshell.h
examples/kpart/main.cpp
examples/kpart/testshellpluginloader.cpp
examples/kpart/testshellpluginloader.h
src/kpart/plasmakpartview.cpp
src/kpart/scripting/rect.cpp
src/plasma/private/package_p.h
src/plasma/private/packagestructure_p.h
src/plasma/private/servicejob_p.h</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>COPYING.LGPL-2 <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127963/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>