<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127710/">https://git.reviewboard.kde.org/r/127710/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change it back to PlasmaComponents.Label and ship it. Thanks!</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127710/diff/2/?file=456464#file456464line194" style="color: black; font-weight: bold; text-decoration: underline;">applet/contents/ui/ListItemBase.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">194</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">PlasmaComponents</span><span class="p">.</span><span class="nx">Label</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">159</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">Label</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should not be changed. If you want to touch it, it should be rewritten to FontMetrics instead.</p></pre>
</div>
</div>
<br />
<p>- David Rosca</p>
<br />
<p>On April 22nd, 2016, 7:18 p.m. UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and David Rosca.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated April 22, 2016, 7:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Branche "cleanup" here : git://anongit.kde.org/clones/plasma-pa/laissus/plasma-pa.git</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Move sourceIndex and sinkIndex properties to a generic one called deviceIndex in the Stream class.</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It helps us to remove the deviceType checks in the KCM (DeviceComboBox)</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Drop sub component support for list items of the applet as it's not used anymore</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As we discussed in a previous RR, it's not planned to use this component so let's clean this up !
I also unified source and sink list items into a generic one.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/contents/ui/DeviceListItemBase.qml <span style="color: grey">(3376c73030470f27a11f0bbedd436fed2676fad5)</span></li>
<li>applet/contents/ui/ListItemBase.qml <span style="color: grey">(d77d25a51b09149a1cf479eec0053184ae8625e6)</span></li>
<li>applet/contents/ui/RootItem2.qml <span style="color: grey">(afcae47d2a9ebfa8f442e9cda93cbf53ac238ec9)</span></li>
<li>applet/contents/ui/SinkListItem.qml <span style="color: grey">(1f9c5df28405d1e5ef65deb2325d293ecb4884b1)</span></li>
<li>applet/contents/ui/SourceListItem.qml <span style="color: grey">(de02c3845b4ab794c560da37c8bfe23c6eff8e46)</span></li>
<li>applet/contents/ui/main.qml <span style="color: grey">(a8dbf7ded667acc6c830f70bf542b38020beaaf8)</span></li>
<li>src/kcm/package/contents/ui/DeviceComboBox.qml <span style="color: grey">(e5a87e733d3009c9f4d08623f65a1c8eede303b7)</span></li>
<li>src/kcm/package/contents/ui/SinkInputView.qml <span style="color: grey">(6e165ad5349129bb10cbae39c0f8300308b44dc6)</span></li>
<li>src/kcm/package/contents/ui/SourceOutputView.qml <span style="color: grey">(3cd978b4bbf8c53e02e098e73d33ed1a169cf0c6)</span></li>
<li>src/kcm/package/contents/ui/StreamListItem.qml <span style="color: grey">(b12e3f3e344fea57cc08085eb68390bac3c11749)</span></li>
<li>src/sinkinput.h <span style="color: grey">(a9a368cc34fcfd42079f064d90f09f52690c5fca)</span></li>
<li>src/sinkinput.cpp <span style="color: grey">(cc5283b71c9af76dcc678644bd3d282bd3473f8a)</span></li>
<li>src/sourceoutput.h <span style="color: grey">(12f4a6c1d5666aea7653765b75aa099e8c1fe422)</span></li>
<li>src/sourceoutput.cpp <span style="color: grey">(66152869618426d8fb27f60d4722816ffbe5144d)</span></li>
<li>src/stream.h <span style="color: grey">(109997c1b3160bb1752d874db218d7f5a3e55f47)</span></li>
<li>src/stream.cpp <span style="color: grey">(55c0c6bf40d7b3d8ba3e97123e9f1eec4c0c9230)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127710/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>