<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127645/">https://git.reviewboard.kde.org/r/127645/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127645/diff/1/?file=456044#file456044line129" style="color: black; font-weight: bold; text-decoration: underline;">src/declarativeimports/plasmacomponents/qmenu.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_INVOKABLE</span> <span class="kt">void</span> <span class="nf">addMenuItem</span><span class="p">(</span><span class="n">QMenuItem</span> <span class="o">*</span><span class="n">item</span><span class="p">,</span> <span class="n">QMenuItem</span> <span class="o">*</span><span class="n">before</span><span class="p">);</span> <span class="c1">// BCI: merge with int before = nullptr</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is not a public library, so the default argument is fine here</p></pre>
</div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On April 13th, 2016, 4:07 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated April 13, 2016, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds a new addMenuItem overload accepting a different MenuItem instance as second parameter, which is used as a position reference for inserting the new item.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This matches QWidget::insertAction in spirit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implicitly allows reordering items in the menu by removing and reinserting if an item already exists (adding actions multiple times was already not supported due to "A QWidget should only have one of each action and adding an action it already has will not cause the same action to be in the widget twice." in the underlying implementation). This is actually quite useful because it aligns well with parenting a PlasmaComponents.MenuItem initially to the menu via Qt.createQmlObject(), then moving it into the desired place before opening the menu.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adding the new overload is necessary for binary compatibility. A //BIC comment is added about merging the two methods in the future, as per the BIC page on the community wiki.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This will be used by the Task Manager applet for dynamically adding actions for recent docs and jump list actions to a task context menu.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qmenu.h <span style="color: grey">(baee963)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenu.cpp <span style="color: grey">(d84f481)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127645/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>