<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127637/">https://git.reviewboard.kde.org/r/127637/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated April 13, 2016, 10:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 553a9bfe53a48d0d042eb8fe18342137ddbfdca1 by Marco Martin to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we have a color in the Plasma theme "highlight" that is basically an accent color used around.. but one of the uses is to use it as a background, such as highlighted text. in that case we don't know what color would be safe for contrasting on top of it for things like the highlighted text color (plasma style used the background color for that, which is incorrect)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/data/plasma/desktoptheme/testtheme/colors <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/plasma/desktoptheme/testtheme/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/themetest.h <span style="color: grey">(b6042c0)</span></li>
<li>autotests/themetest.cpp <span style="color: grey">(2165bef)</span></li>
<li>src/declarativeimports/core/colorscope.h <span style="color: grey">(38e7cc8)</span></li>
<li>src/declarativeimports/core/colorscope.cpp <span style="color: grey">(98ff3ab)</span></li>
<li>src/declarativeimports/core/quicktheme.h <span style="color: grey">(79db53c)</span></li>
<li>src/declarativeimports/core/quicktheme.cpp <span style="color: grey">(3ef5b88)</span></li>
<li>src/declarativeimports/plasmastyle/TextAreaStyle.qml <span style="color: grey">(f5be27c)</span></li>
<li>src/declarativeimports/plasmastyle/TextFieldStyle.qml <span style="color: grey">(447d7e3)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(603cf0a)</span></li>
<li>src/plasma/theme.h <span style="color: grey">(3f49719)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>