<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127637/">https://git.reviewboard.kde.org/r/127637/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 12th, 2016, 11:38 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127637/diff/2/?file=455999#file455999line505" style="color: black; font-weight: bold; text-decoration: underline;">src/plasma/private/theme_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">505</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">stylesheet</span> <span class="o">+=</span> <span class="n">skel</span><span class="p">.</span><span class="n">arg</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"HighlightedText"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"%viewhighlightedtextcolor"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This still has the same bug I pointed out in the first review. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should be complementaryhighlightedtextcolor not view</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah, correction was uncommitted in git, didn't show up in the diff, sorry</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On April 12th, 2016, 3:13 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated April 12, 2016, 3:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we have a color in the Plasma theme "highlight" that is basically an accent color used around.. but one of the uses is to use it as a background, such as highlighted text. in that case we don't know what color would be safe for contrasting on top of it for things like the highlighted text color (plasma style used the background color for that, which is incorrect)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/data/plasma/desktoptheme/testtheme/colors <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/plasma/desktoptheme/testtheme/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/themetest.h <span style="color: grey">(b6042c0)</span></li>
<li>autotests/themetest.cpp <span style="color: grey">(2165bef)</span></li>
<li>src/declarativeimports/core/colorscope.h <span style="color: grey">(38e7cc8)</span></li>
<li>src/declarativeimports/core/colorscope.cpp <span style="color: grey">(98ff3ab)</span></li>
<li>src/declarativeimports/core/quicktheme.h <span style="color: grey">(79db53c)</span></li>
<li>src/declarativeimports/core/quicktheme.cpp <span style="color: grey">(3ef5b88)</span></li>
<li>src/declarativeimports/plasmastyle/TextAreaStyle.qml <span style="color: grey">(f5be27c)</span></li>
<li>src/declarativeimports/plasmastyle/TextFieldStyle.qml <span style="color: grey">(447d7e3)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(603cf0a)</span></li>
<li>src/plasma/theme.h <span style="color: grey">(3f49719)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>