<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127540/">https://git.reviewboard.kde.org/r/127540/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Virtual streams appear when virtual devices are defined in PulseAudio configuration (eg: combined output for classic analog and HDMI)
Those virtual streams aren't properly shown in both the KCM and the applet, producing ghost entries.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screens attached.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added a new property to the Stream object to identify if a stream is real or not.
Then, a proxy model takes care of the filtering in the KCM and the applet.
For now, only real devices are shown. But we could add a combobox later, at least in the KCM, to be able to display Virtual, Real or both kind of streams. (like pavucontrol)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS : Other review requests are coming (sink selection for streams) but needs some rebasing with David Rosca's latest patches.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/contents/ui/main.qml <span style="color: grey">(cbe63ced145cd6e755511d025df84a536976eac4)</span></li>
<li>src/kcm/package/contents/ui/StreamView.qml <span style="color: grey">(b08c87a2452cadd13bae5b0b94b57c3d8f531b3b)</span></li>
<li>src/kcm/package/contents/ui/main.qml <span style="color: grey">(3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c)</span></li>
<li>src/pulseaudio.h <span style="color: grey">(9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517)</span></li>
<li>src/pulseaudio.cpp <span style="color: grey">(14887849a04ff2fb3ded5d0d5e60ec3ce4c40745)</span></li>
<li>src/qml/plugin.cpp <span style="color: grey">(5743253f9a7b8283d2bcbeeb081d0706ba4c7b12)</span></li>
<li>src/stream.h <span style="color: grey">(b5e09ebaaa0b812f3db81e269671640c783e7c87)</span></li>
<li>src/stream.cpp <span style="color: grey">(d8f390805e96bbc2dc69ca02520c049b2ca0a4b6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127540/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png">KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png">Applet</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>