<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127484/">https://git.reviewboard.kde.org/r/127484/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2016, 4:53 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Great that you're bringing streams back to the applet, much appreciated!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree with Kai that we should hide the technical stream names, they are of no use to anybody not deeply interested in PulseAudio. If an application has more than one stream, it only makes sense to show anything besides the applicaiton name if it has any meaning for the user. Distinguishing multiple streams based on some purely technical identifier gives zero useful information. If we have no human-readable information to distinguish streams from the same application, we might as well fall back to simply numbering them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the redirection of streams to devices: What I'd like to see from a user perspective is simply dragging and dropping. So users could grab a stream, drag it over to the devices tab and then drop it on a device. That would be kind of intuitive and wouldn't clutter the UI with dropdown arrows. I don't know if that is technically feasible, of course.</p></pre>
</blockquote>
<p>On March 24th, 2016, 5:10 p.m. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree with Kai that we should hide the technical stream names, they are of no use to anybody not deeply interested in PulseAudio....</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Alright, but that's for another patch. Currently it only shows name that exposes model.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the redirection of streams to devices: What I'd like to see from a user perspective is simply dragging and dropping. So users could grab a stream, drag it over to the devices tab and then drop it on a device. That would be kind of intuitive and wouldn't clutter the UI with dropdown arrows. I don't know if that is technically feasible, of course.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is possible, but as the streams are now displayed in separate tab, I think it would be extra awkward. First you will need to change the tab by dragging the stream on the "Devices" tab and then you'll need to find the right device. As the systemtray popup is small, if you have more devices then you would need to also scroll the view.
It is also much faster with the combobox than dragging.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In other applets (print, network, bluetooth, ..), we already have the pattern of showing additional options when clicking on item. So maybe remove the arrow and indicate the additional actions with hover highlight (as in network applet)?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh and also currently there is issue with scrolling of the view with mouse wheel that will be interrupted by volume sliders (or even may accidentally change volume). So I'm thinking of completely disabling scrolling with mouse wheel (as there doesn't seem to be better fix while having the option to change volume with wheel on sliders), which would make the scrollbar and flick with left mouse the only way to scroll it. And that would make the dragging impossible.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In other applets (print, network, bluetooth, ..), we already have the pattern of showing additional options when clicking on item. So maybe remove the arrow and indicate the additional actions with hover highlight (as in network applet)?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, that makes sense!</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 24th, 2016, 2:28 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 24, 2016, 2:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Applet now have two tabs: Devices and Streams.
If there are more audo devices, streams can be moved between them with combobox that is visible after clicking on stream item.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 352042
BUG: 353232</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything seems to work fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/contents/ui/ListItemBase.qml <span style="color: grey">(2e31eeb)</span></li>
<li>applet/contents/ui/SinkInputListItem.qml <span style="color: grey">(3867007)</span></li>
<li>applet/contents/ui/SourceOutputListItem.qml <span style="color: grey">(3b684fc)</span></li>
<li>applet/contents/ui/StreamListItemBase.qml <span style="color: grey">(7c0af12)</span></li>
<li>applet/contents/ui/main.qml <span style="color: grey">(bf6f683)</span></li>
<li>src/pulseaudio.h <span style="color: grey">(9fc9656)</span></li>
<li>src/pulseaudio.cpp <span style="color: grey">(1488784)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127484/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png">applet-devices.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png">applet-streams.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>