<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127306/">https://git.reviewboard.kde.org/r/127306/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127306/diff/2/?file=448497#file448497line32" style="color: black; font-weight: bold; text-decoration: underline;">kcms/touchpad/src/backends/x11/synapticstouchpad.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">m_resX</span><span class="p">,</span> <span class="n">m_resY</span><span class="p">;</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My initial intention is to move this synaptics member into SynaptcsTouchpad but later I found they are accessed in XlibTouchpad directly so I move them to XlibTouchpad again for now. (and forgot to delete thoses ones in SynatpcsTouchpad, sorry for that).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But now I take a closer look, int m_resX, m_resY; QStringList m_scaleByResX, m_scaleByResY, m_toRadians; are only used in getPropertyScale().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So can you keep "int m_resX, m_resY; QStringList m_scaleByResX, m_scaleByResY, m_toRadians;" in SynapticsTouchpad, and make getPropertyScale a virtual function. Make a new default implemetation of getPropertyScale in XlibTouchpad that simply returns 1.0.</p></pre>
</div>
</div>
<br />
<p>- Xuetian Weng</p>
<br />
<p>On March 8th, 2016, 9:11 p.m. UTC, Rajeesh K V wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson and Xuetian Weng.</div>
<div>By Rajeesh K V.</div>
<p style="color: grey;"><i>Updated March 8, 2016, 9:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=359460">359460</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes few things:
1. Remove redefined members of parent class XlibTouchpad from SynapticsTouchpad class fixing wrong scroll delta values.
2. Enlarge vertical,horizontal&circular scroll delta and maxtapmove allowing value more than 100. The max value supported by driver is 1000.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would like to get this fix in 5.6 final.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built the RPM, compile tested and locally tested. Bug reporters confirm patch fixes the issue.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/touchpad/src/backends/x11/synapticstouchpad.h <span style="color: grey">(de75125)</span></li>
<li>kcms/touchpad/src/backends/x11/synapticstouchpad.cpp <span style="color: grey">(1e01894)</span></li>
<li>kcms/touchpad/src/kcm/touchpad.kcfg <span style="color: grey">(d4d127c)</span></li>
<li>kcms/touchpad/src/kcm/ui/scroll.ui <span style="color: grey">(d1c2f76)</span></li>
<li>kcms/touchpad/src/kcm/ui/tap.ui <span style="color: grey">(389db5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>