<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127285/">https://git.reviewboard.kde.org/r/127285/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use empty service name to watch all service is not a supported feature of QDBusServiceWatcher. https://bugreports.qt.io/browse/QTBUG-51683 is closed. So for now we have to use QDBusConnectionInterface::serviceOwnerChanged for this use case.</p></pre>
<br />
<p>- Xuetian Weng</p>
<br />
<p>On March 5th, 2016, 5:48 a.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Aleix Pol Gonzalez.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated March 5, 2016, 5:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not sure if this is an intented upstream change (I reported it anyway https://bugreports.qt.io/browse/QTBUG-51683 ), but QDBusServiceWatcher can't watch all service anymore in Qt 5.6 RC with empty service name string.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's simple use the "deprecated" QDBusConnectionInterface::serviceOwnerChanged signal to do this work, which is also used by qdbusviewer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change mpris2 dataengine and systemtray to use QDBusConnectionInterface::serviceOwnerChanged.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">mpris2 dataengine and mediacontroller now back to work with qt 5.6.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h <span style="color: grey">(9e59501)</span></li>
<li>applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp <span style="color: grey">(94c3efc)</span></li>
<li>dataengines/mpris2/mpris2engine.cpp <span style="color: grey">(064ca60)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>