<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127248/">https://git.reviewboard.kde.org/r/127248/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah, it makes sense
I did briefly try to port the bbc one some time ago and yeah they seem to either having changed the api or removed the possibility to fetch the weather info with a sane web api completely (worth to investigate)</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On March 1st, 2016, 8:10 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 1, 2016, 8:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port was simple, by following the one you did for the wettercom ion :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sadly found that the bbc one no longer works, at least the location search url used is redirected to the normal start webpage. So I still propose to apply the changes so it builds, but disable from build.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And the debianweather engine no longer has a service to use, as reported by its author on #plasma:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[20:28] <svuorela> frinring_: it was a weather service translating the state of the debian archive into weather.
[20:28] <svuorela> if the weather was cloudy or heavy rain, consider not upgrading
[20:28] <frinring_> indicates a project of fun :)
[20:29] <-- Nightrose (~lydia@kde/lydia) hat diesen Server verlassen (Ping timeout: 276 seconds).
[20:29] <frinring_> svuorela: "was" means it is dead? and we could just remove the plugin for it?
[20:29] <svuorela> I think it might be dead yes . let me investigate
[20:34] <svuorela> frinring_: yeah. it seems dead.
[20:34] <svuorela> feel free to fix with git rm
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/weather/ions/CMakeLists.txt <span style="color: grey">(e59e0db)</span></li>
<li>dataengines/weather/ions/bbcukmet/CMakeLists.txt <span style="color: grey">(a8f1ec1)</span></li>
<li>dataengines/weather/ions/bbcukmet/ion_bbcukmet.h <span style="color: grey">(9dbdbf7)</span></li>
<li>dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp <span style="color: grey">(d2d47fa)</span></li>
<li>dataengines/weather/ions/debianweather/CMakeLists.txt <span style="color: grey">(05c217d)</span></li>
<li>dataengines/weather/ions/debianweather/ion-debianweather.desktop <span style="color: grey">(650e4e7)</span></li>
<li>dataengines/weather/ions/debianweather/iondebianweather.h <span style="color: grey">(a3ca110)</span></li>
<li>dataengines/weather/ions/debianweather/iondebianweather.cpp <span style="color: grey">(6525144)</span></li>
<li>dataengines/weather/ions/envcan/CMakeLists.txt <span style="color: grey">(a3daa55)</span></li>
<li>dataengines/weather/ions/envcan/ion_envcan.h <span style="color: grey">(19407d6)</span></li>
<li>dataengines/weather/ions/envcan/ion_envcan.cpp <span style="color: grey">(56efc7a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127248/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>