<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sun, Feb 28, 2016 at 12:18 AM, Weng Xuetian <span dir="ltr"><<a href="mailto:wengxt@gmail.com" target="_blank">wengxt@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>pixelColor is only in Qt 5.6.<br><br></div>Does plasma-frameworks depend on Qt 5.6 right now?<br></div></blockquote><div><br></div><div>No, fixed now.<br><br></div><div>David<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Sat, Feb 27, 2016 at 12:25 PM, David Rosca <span dir="ltr"><<a href="mailto:nowrep@gmail.com" target="_blank">nowrep@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span>
   <table style="border:1px #c9c399 solid;border-radius:6px" cellpadding="12" bgcolor="#f9f3c9" width="100%">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127103/" target="_blank">https://git.reviewboard.kde.org/r/127103/</a>
     </td>
    </tr>
   </tbody></table>
   <br>



</span><table style="border:1px gray solid;border-radius:6px" cellpadding="12" bgcolor="#e0e0e0" width="100%">
 <tbody><tr>
  <td>
   <h1 style="margin:0;padding:0;font-size:10pt">This change has been marked as submitted.</h1>
  </td>
 </tr>
</tbody></table>
<br>


<table style="border:1px #888a85 solid;border-radius:6px" cellpadding="12" cellspacing="0" bgcolor="#fefadf" width="100%">
 <tbody><tr>
  <td><span>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>


</span><p style="color:grey"><i>Updated Feb. 27, 2016, 8:25 p.m.</i></p>



<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" bgcolor="#ffffff" width="100%">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Submitted with commit 526915895b243ecf96298c9175a24dbf4b153393 by David Rosca to branch master.</pre>
  </td>
 </tr>
</tbody></table><span>







<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
plasma-framework
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" bgcolor="#ffffff" width="100%">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Add some tests for IconItem.
Also found one issue in animation when quickly changing source, first frame will be rendered with wrong icon.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" bgcolor="#ffffff" width="100%">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Tests pass localy, I used only icons that are shipped with plasma-framework breeze theme so it should work on CI too.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">There is also test that checks if animation is not running after the item was hidden. This needs <a href="https://git.reviewboard.kde.org/r/122859/" target="_blank">https://git.reviewboard.kde.org/r/122859/</a>, so this should land only after that.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>autotests/CMakeLists.txt <span style="color:grey">(258adb8)</span></li>

 <li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span style="color:grey">(PRE-CREATION)</span></li>

 <li>autotests/data/view.qml <span style="color:grey">(PRE-CREATION)</span></li>

 <li>autotests/iconitemtest.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>autotests/iconitemtest.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>src/declarativeimports/core/iconitem.cpp <span style="color:grey">(085f284)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127103/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>






  </span></td>
 </tr>
</tbody></table>



  </div>
 </div>


<br></div></div>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org" target="_blank">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div>