<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127201/">https://git.reviewboard.kde.org/r/127201/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2016, 5:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes for David Rosca's comment</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well.. the bug should be obvious:
1. QString iconPath overrides the iconPath in a higher scope. introduced in https://git.reviewboard.kde.org/r/126168/
2. iconPath not assigned, also introduced in https://git.reviewboard.kde.org/r/126168/
3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tested with qmlscene with Plasma.IconItem.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span style="color: grey">(8739af5)</span></li>
<li>autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme/apps/48/konversation.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme/index.theme <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/iconitemtest.h <span style="color: grey">(9fd3063)</span></li>
<li>autotests/iconitemtest.cpp <span style="color: grey">(ea98c9d)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: grey">(c65a9a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127201/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>