<div>dfaure added a comment.</div><br /><div><div><p>Yes, KAssistantDialog says</p>
<div class="remarkup-code-block" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="border: 1px solid #f1c40f;
background: #fdf5d4;
font-size: 10x;
padding: 8px;">buttonBox->setStandardButtons(QDialogButtonBox::Cancel | QDialogButtonBox::Help);</pre></div>
<p>If you then call addButton(Help) you get another one.</p>
<p>I do wonder if KAssistantDialog should be doing this indeed. It means it offers a button that does nothing, by default, and just hopes that the app will connect to it.</p>
<p><a href="https://git.reviewboard.kde.org/r/123939/" class="remarkup-link" target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/123939/</a> added this button, but I think it would have been better to let the apps do it. But now we can't take it out again, code that calls button(Help) would get a null pointer and crash...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1025" rel="noreferrer">https://phabricator.kde.org/D1025</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, dfaure<br /><strong>Cc: </strong>plasma-devel<br /></div>