<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126793/">https://git.reviewboard.kde.org/r/126793/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 23rd, 2016, 7:08 p.m. IST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry for the massive delay. That's really messed up on our side.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We have a feature freeze next wednesday, it would be great to get this all merged by then. I just had a few tiny comments, but I think we're all good to go.</p></pre>
</blockquote>
<p>On February 23rd, 2016, 7:29 p.m. IST, <b>Lars Pontoppidan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No worries - I just hope we can make it to the release :)</p></pre>
</blockquote>
<p>On February 23rd, 2016, 8:20 p.m. IST, <b>Lars Pontoppidan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All issues fixed - how should I proceed from here?</p></pre>
</blockquote>
<p>On February 23rd, 2016, 9:38 p.m. IST, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given that you have a Ship It, you should be able to merge your branch to master and push it (but don't forget the REVIEW: keyword to close this review) before feature freeze.</p></pre>
</blockquote>
<p>On February 24th, 2016, 4:08 p.m. IST, <b>Lars Pontoppidan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've clicked the "Ship It!" button - I didn't see anything happening?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can I ask you to baby-step guide me on how to do this correctly?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm on the branch larpon/mediaframe - all ready to merge...
Then I do... <insert help here> :)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">git checkout master
git merge larpon/mediaframe</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in merge commit message add,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 126793</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and then git push origin master</p></pre>
<br />
<p>- Bhushan</p>
<br />
<p>On February 23rd, 2016, 8:18 p.m. IST, Lars Pontoppidan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Lars Pontoppidan.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2016, 8:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KF5 version of the (Picture) Frame widget</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdeplasma-addons builds on Kubuntu 15.10.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(ed938f8)</span></li>
<li>applets/mediaframe/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/ui/ConfigPaths.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframe.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframe.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframeplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframeplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126793/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>