<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127085/">https://git.reviewboard.kde.org/r/127085/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2016, 12:09 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Breeze theme version needs bumping as you need the cache to clear.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are you planning on migrating existing users onto breeze-light?</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:13 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hmm no, I wanted to have existing users to the new one, if they don't have weird color schemes they don't notice, otherwise they'll find the whole desktop on the same color scheme, that i think makes sense (they can still go back to breeze light)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the vdg thinks that it's not an unacceptable default change, we can do a kconfupdate script</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:20 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">how does the monochrome system tray icons look like cause they use also the colors from system color?</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:21 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, like the k menu</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:24 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it possible to 1. change the behavior and 2. do the kde applications (e.g. dolphin) use also colored monochrome icons?</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:26 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">neither of those, sorry</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:27 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It look like a biger change so how can I test your review?</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:28 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i want in the long run have qwidget applications to be able to use colored icons, and thoise are all bady steps for it.
but as you know for qwidget applicatons is all a problem 10 times as hard</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:33 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would it be possible to change also the color of some application elements like menu, toolbar, ... like you see it here https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/photo59126345614076845.jpg Alex from the VDG make it and it would be awesome to integrate something like "material stuff" in the KCM UI and as you do some stuff here, ... You know VDG has nice ideas but is always searching for some dev.</p></pre>
</blockquote>
<p>On February 16th, 2016, 12:37 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that is unrelated.. it would be a change for the Breeze c++ theme and yes i guess it's possible.
opinion/help of Hugo would be the best for that.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The issue here is that this hands over a large amount of power to the user, if she sets a colour theme that will make some icons tricky to see - then that is what will happen. This doesn't stop us from releasing a "hardcoded" plasma theme - just like the "old Plasma 5.4 theme" still available. The idea here is that IF a user want to swap around color themes, make one herself - then she is most probably capable of looking for the effects of that.</p></pre>
<br />
<p>- Jens</p>
<br />
<p>On February 16th, 2016, 12:28 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Jens Reuterberg.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2016, 12:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this makes the default plasma theme follow system colors, there are still "breeze light" and "breeze dark" themes that behave like the old two</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/CMakeLists.txt <span style="color: grey">(3087c17)</span></li>
<li>src/desktoptheme/breeze-light/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze-light/colors <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze-light/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze/CMakeLists.txt <span style="color: grey">(2e28287)</span></li>
<li>src/desktoptheme/breeze/colors <span style="color: grey">(d701701)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127085/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/24f7dc82-1d66-4052-bc6f-af4aab0f15df__color1.png">color1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/93188d4f-242a-46ac-94a7-182ed600817b__color2.png">color2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/5151b63c-476b-4ff3-a653-42bf8168836f__color3.png">color3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/41febde6-795d-437c-b17e-ace92c84ea73__color4.png">color4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>