<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126994/">https://git.reviewboard.kde.org/r/126994/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suppose that getting rid of KDELibs4Support isn't a bad thing at all if it doesn't provide crucial/central functionality.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: you're welcome :)</p></pre>
<br />
<p>- René J.V. Bertin</p>
<br />
<p>On February 5th, 2016, 9:16 p.m. CET, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and René J.V. Bertin.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2016, 9:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I saw in another RR, the simple fact of using KDELibs4Support in part of a project makes the whole project rely on Qt4Support. That's bad especially in cases where KDELibs4Support is optional, because it will lead to unpredictable results.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/plugin/host.cpp <span style="color: grey">(e529aeb)</span></li>
<li>components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp <span style="color: grey">(cba87ec)</span></li>
<li>components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h <span style="color: grey">(e9d7ef3)</span></li>
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp <span style="color: grey">(8a5ba91)</span></li>
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h <span style="color: grey">(20fb98e)</span></li>
<li>components/shellprivate/widgetexplorer/widgetexplorer.cpp <span style="color: grey">(7816614)</span></li>
<li>dataengines/CMakeLists.txt <span style="color: grey">(9ee93d8)</span></li>
<li>dataengines/dict/dictengine.cpp <span style="color: grey">(d851268)</span></li>
<li>dataengines/mpris2/mpris2engine.h <span style="color: grey">(ea49515)</span></li>
<li>dataengines/mpris2/multiplexedservice.h <span style="color: grey">(2ab4e6b)</span></li>
<li>dataengines/mpris2/playercontainer.cpp <span style="color: grey">(6c4c875)</span></li>
<li>dataengines/share/shareprovider.cpp <span style="color: grey">(ac66fd3)</span></li>
<li>dataengines/statusnotifieritem/statusnotifieritemsource.cpp <span style="color: grey">(097f110)</span></li>
<li>drkonqi/bugzillaintegration/bugzillalib.cpp <span style="color: grey">(802c5fb)</span></li>
<li>drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp <span style="color: grey">(e60fb14)</span></li>
<li>drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp <span style="color: grey">(4f8f4ea)</span></li>
<li>drkonqi/drkonqi.cpp <span style="color: grey">(b12c118)</span></li>
<li>libtaskmanager/abstractgroupableitem.cpp <span style="color: grey">(9b86cf1)</span></li>
<li>libtaskmanager/groupmanager.cpp <span style="color: grey">(12b18b0)</span></li>
<li>libtaskmanager/strategies/manualgroupingstrategy.cpp <span style="color: grey">(b37ac35)</span></li>
<li>libtaskmanager/strategies/programgroupingstrategy.cpp <span style="color: grey">(6b91bfe)</span></li>
<li>libtaskmanager/taskactions.cpp <span style="color: grey">(d1ddf9c)</span></li>
<li>libtaskmanager/taskactions_p.h <span style="color: grey">(535ea5f)</span></li>
<li>libtaskmanager/taskitem.cpp <span style="color: grey">(3b2a418)</span></li>
<li>libtaskmanager/tasksmodel.h <span style="color: grey">(8decf0b)</span></li>
<li>libtaskmanager/tasksmodel.cpp <span style="color: grey">(0abdd93)</span></li>
<li>runners/bookmarks/faviconfromblob.cpp <span style="color: grey">(540db9c)</span></li>
<li>runners/bookmarks/tests/testchromebookmarks.cpp <span style="color: grey">(718e765)</span></li>
<li>shell/currentcontainmentactionsmodel.h <span style="color: grey">(0c27a20)</span></li>
<li>shell/currentcontainmentactionsmodel.cpp <span style="color: grey">(d442985)</span></li>
<li>shell/kidenticongenerator.cpp <span style="color: grey">(4e4b25a)</span></li>
<li>shell/panelview.cpp <span style="color: grey">(0eaf553)</span></li>
<li>shell/scripting/backportglobal.h <span style="color: grey">(988b14e)</span></li>
<li>shell/scripting/containment.cpp <span style="color: grey">(5e42bee)</span></li>
<li>shell/scripting/widget.cpp <span style="color: grey">(984e666)</span></li>
<li>wallpapers/image/backgroundlistmodel.h <span style="color: grey">(d639b03)</span></li>
<li>wallpapers/image/backgroundlistmodel.cpp <span style="color: grey">(b4f81da)</span></li>
<li>wallpapers/image/image.h <span style="color: grey">(295ba22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126994/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>