<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126949/">https://git.reviewboard.kde.org/r/126949/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 2nd, 2016, 10:17 a.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">maybe not oxygen, but i want to point out that i <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">do</em> maintain the Air theme</p></pre>
</blockquote>
<p>On February 2nd, 2016, 4:02 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Then we got some fixing to do as this is how Air looks like here: http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of the controls)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can file all these as bugs if you want.</p></pre>
</blockquote>
<p>On February 2nd, 2016, 4:50 p.m. CET, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are missing icons from the oxygen plasma theme and in the future also in oxygen-icons. I will work on this but without this the theme is not that broken as you show in the screenshot when you use everything from oxygen (plasma theme, icons, window decoration, ...) https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png</p></pre>
</blockquote>
<p>On February 2nd, 2016, 5:15 p.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's fine they are missing in the plasma themes, those themes were designed to have systray icons explicitly different (to change that, all of their icons can just be deleted and they will fallback)</p></pre>
</blockquote>
<p>On February 2nd, 2016, 5:16 p.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what do you mean with the bottom frame of the controls?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@andreas - This is only about the Plasma theme, using different icons or window decoration has zero impact on the theme itself.
The Plasma theme has many broken things, here's a list of what I've noticed in just couple minutes:
* task manager buttons have too big margins; the icons are tiny and text is gone
* all button-based controls have strangely stretched bottom frame
* kicker has artifacts in the submenu corners that touch the parent menus
* the selection box in listviews is smaller than the items, making the icons in systray popup be painted outside of the selection rectangle
* placeholder text has no inner left padding on text inputs
* the blinking cursor in text inputs can be painted partially outside the input field
* sliders have artifacts in corners
* network manager has no selection painted on hover, it's missing quite a few graphical things it seems
* everything has a huuuuge shadow (although that may be a feature)
...it's not just about setting the theme and looking at the default desktop and making a screenshot. You have to use it for a while.
These are all fixable, but given the last useful commit in air/ was June 2014, I had considered this as unmaintained.</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 1st, 2016, 8:30 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2016, 8:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=358533">358533</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">They are untested, unmaintained and most importantly, broken.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's remove them from our releases and move them to kde-look.org for grabs.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/air/CMakeLists.txt <span style="color: grey">(40ea382)</span></li>
<li>src/desktoptheme/air/colors <span style="color: grey">(5c4e53d)</span></li>
<li>src/desktoptheme/air/dialogs/background.svgz <span style="color: grey">(81ef460)</span></li>
<li>src/desktoptheme/air/dialogs/kickoff.svgz <span style="color: grey">(40e2ae6)</span></li>
<li>src/desktoptheme/air/dialogs/krunner.svgz <span style="color: grey">(1f6a64f)</span></li>
<li>src/desktoptheme/air/icons/amarok.svgz <span style="color: grey">(e3c157e)</span></li>
<li>src/desktoptheme/air/icons/audio.svgz <span style="color: grey">(540cc77)</span></li>
<li>src/desktoptheme/air/icons/battery.svgz <span style="color: grey">(88f864e)</span></li>
<li>src/desktoptheme/air/icons/configure.svgz <span style="color: grey">(a433b3c)</span></li>
<li>src/desktoptheme/air/icons/device.svgz <span style="color: grey">(23df094)</span></li>
<li>src/desktoptheme/air/icons/document.svgz <span style="color: grey">(6e89dd8)</span></li>
<li>src/desktoptheme/air/icons/edit.svgz <span style="color: grey">(d0e1ca4)</span></li>
<li>src/desktoptheme/air/icons/go.svgz <span style="color: grey">(ad3a4b2)</span></li>
<li>src/desktoptheme/air/icons/kget.svgz <span style="color: grey">(1f1702f)</span></li>
<li>src/desktoptheme/air/icons/klipper.svgz <span style="color: grey">(4afd33c)</span></li>
<li>src/desktoptheme/air/icons/konv_message.svgz <span style="color: grey">(10e31cd)</span></li>
<li>src/desktoptheme/air/icons/konversation.svgz <span style="color: grey">(376211a)</span></li>
<li>src/desktoptheme/air/icons/kopete.svgz <span style="color: grey">(5f41c4c)</span></li>
<li>src/desktoptheme/air/icons/korgac.svgz <span style="color: grey">(8c8f700)</span></li>
<li>src/desktoptheme/air/icons/kpackagekit.svgz <span style="color: grey">(234e6da)</span></li>
<li>src/desktoptheme/air/icons/ktorrent.svgz <span style="color: grey">(dc623d8)</span></li>
<li>src/desktoptheme/air/icons/list.svgz <span style="color: grey">(0a25bb0)</span></li>
<li>src/desktoptheme/air/icons/media.svgz <span style="color: grey">(23653bd)</span></li>
<li>src/desktoptheme/air/icons/nepomuk.svgz <span style="color: grey">(5c8545e)</span></li>
<li>src/desktoptheme/air/icons/network.svgz <span style="color: grey">(a8e8b16)</span></li>
<li>src/desktoptheme/air/icons/notification.svgz <span style="color: grey">(db12260)</span></li>
<li>src/desktoptheme/air/icons/preferences.svgz <span style="color: grey">(12e6588)</span></li>
<li>src/desktoptheme/air/icons/printer.svgz <span style="color: grey">(199ab95)</span></li>
<li>src/desktoptheme/air/icons/quassel.svgz <span style="color: grey">(b004749)</span></li>
<li>src/desktoptheme/air/icons/slc.svgz <span style="color: grey">(9fd376b)</span></li>
<li>src/desktoptheme/air/icons/wallet.svgz <span style="color: grey">(4ad3691)</span></li>
<li>src/desktoptheme/air/icons/window.svgz <span style="color: grey">(eecc37f)</span></li>
<li>src/desktoptheme/air/icons/zoom.svgz <span style="color: grey">(c159491)</span></li>
<li>src/desktoptheme/air/metadata.desktop <span style="color: grey">(0be4bd5)</span></li>
<li>src/desktoptheme/air/opaque/dialogs/background.svgz <span style="color: grey">(d2329ff)</span></li>
<li>src/desktoptheme/air/opaque/dialogs/krunner.svgz <span style="color: grey">(2a2134f)</span></li>
<li>src/desktoptheme/air/opaque/widgets/extender-background.svgz <span style="color: grey">(e810ba4)</span></li>
<li>src/desktoptheme/air/opaque/widgets/panel-background.svgz <span style="color: grey">(2a2134f)</span></li>
<li>src/desktoptheme/air/opaque/widgets/tooltip.svgz <span style="color: grey">(2a2134f)</span></li>
<li>src/desktoptheme/air/translucent/dialogs/background.svgz <span style="color: grey">(9b68062)</span></li>
<li>src/desktoptheme/air/translucent/dialogs/krunner.svgz <span style="color: grey">(4c48b52)</span></li>
<li>src/desktoptheme/air/translucent/widgets/extender-background.svgz <span style="color: grey">(799e798)</span></li>
<li>src/desktoptheme/air/translucent/widgets/panel-background.svgz <span style="color: grey">(7783e3b)</span></li>
<li>src/desktoptheme/air/translucent/widgets/tooltip.svgz <span style="color: grey">(7783e3b)</span></li>
<li>src/desktoptheme/air/widgets/action-overlays.svgz <span style="color: grey">(4259105)</span></li>
<li>src/desktoptheme/air/widgets/actionbutton.svgz <span style="color: grey">(e1713ea)</span></li>
<li>src/desktoptheme/air/widgets/analog_meter.svgz <span style="color: grey">(f0d2163)</span></li>
<li>src/desktoptheme/air/widgets/arrows.svgz <span style="color: grey">(b987b32)</span></li>
<li>src/desktoptheme/air/widgets/background.svgz <span style="color: grey">(174a8fc)</span></li>
<li>src/desktoptheme/air/widgets/bar_meter_horizontal.svgz <span style="color: grey">(8031b77)</span></li>
<li>src/desktoptheme/air/widgets/bar_meter_vertical.svgz <span style="color: grey">(1b0660d)</span></li>
<li>src/desktoptheme/air/widgets/branding.svgz <span style="color: grey">(c6316fb)</span></li>
<li>src/desktoptheme/air/widgets/busywidget.svgz <span style="color: grey">(f638cfb)</span></li>
<li>src/desktoptheme/air/widgets/button.svgz <span style="color: grey">(2c529bf)</span></li>
<li>src/desktoptheme/air/widgets/calendar.svgz <span style="color: grey">(2d80a49)</span></li>
<li>src/desktoptheme/air/widgets/checkmarks.svgz <span style="color: grey">(dcf2924)</span></li>
<li>src/desktoptheme/air/widgets/clock.svgz <span style="color: grey">(3839dac)</span></li>
<li>src/desktoptheme/air/widgets/configuration-icons.svgz <span style="color: grey">(9b212d3)</span></li>
<li>src/desktoptheme/air/widgets/containment-controls.svgz <span style="color: grey">(a3166ce)</span></li>
<li>src/desktoptheme/air/widgets/dragger.svgz <span style="color: grey">(3629591)</span></li>
<li>src/desktoptheme/air/widgets/extender-background.svgz <span style="color: grey">(4003079)</span></li>
<li>src/desktoptheme/air/widgets/extender-dragger.svgz <span style="color: grey">(5bf3e0f)</span></li>
<li>src/desktoptheme/air/widgets/frame.svgz <span style="color: grey">(327c284)</span></li>
<li>src/desktoptheme/air/widgets/glowbar.svgz <span style="color: grey">(4a8a464)</span></li>
<li>src/desktoptheme/air/widgets/identiconshapes.svgz <span style="color: grey">(67fe725)</span></li>
<li>src/desktoptheme/air/widgets/identicontheme.svgz <span style="color: grey">(ad881cd)</span></li>
<li>src/desktoptheme/air/widgets/labeltexture.svgz <span style="color: grey">(f52a78d)</span></li>
<li>src/desktoptheme/air/widgets/line.svgz <span style="color: grey">(70efca4)</span></li>
<li>src/desktoptheme/air/widgets/lineedit.svgz <span style="color: grey">(22347db)</span></li>
<li>src/desktoptheme/air/widgets/listitem.svgz <span style="color: grey">(ec7e89a)</span></li>
<li>src/desktoptheme/air/widgets/media-delegate.svgz <span style="color: grey">(e28b313)</span></li>
<li>src/desktoptheme/air/widgets/monitor.svgz <span style="color: grey">(13a22fd)</span></li>
<li>src/desktoptheme/air/widgets/pager.svgz <span style="color: grey">(2dcbbcd)</span></li>
<li>src/desktoptheme/air/widgets/panel-background.svgz <span style="color: grey">(080a65d)</span></li>
<li>src/desktoptheme/air/widgets/picker.svgz <span style="color: grey">(c15eb0e)</span></li>
<li>src/desktoptheme/air/widgets/plot-background.svgz <span style="color: grey">(f4c7957)</span></li>
<li>src/desktoptheme/air/widgets/scrollbar.svgz <span style="color: grey">(c0ea8f5)</span></li>
<li>src/desktoptheme/air/widgets/scrollwidget.svgz <span style="color: grey">(3281ad6)</span></li>
<li>src/desktoptheme/air/widgets/slider.svgz <span style="color: grey">(107e627)</span></li>
<li>src/desktoptheme/air/widgets/systemtray.svgz <span style="color: grey">(6e15351)</span></li>
<li>src/desktoptheme/air/widgets/tabbar.svgz <span style="color: grey">(8e6684e)</span></li>
<li>src/desktoptheme/air/widgets/tasks.svgz <span style="color: grey">(f6ed0a9)</span></li>
<li>src/desktoptheme/air/widgets/toolbar.svgz <span style="color: grey">(09ce09f)</span></li>
<li>src/desktoptheme/air/widgets/toolbox.svgz <span style="color: grey">(138df24)</span></li>
<li>src/desktoptheme/air/widgets/tooltip.svgz <span style="color: grey">(080a65d)</span></li>
<li>src/desktoptheme/air/widgets/translucentbackground.svgz <span style="color: grey">(2aea33b)</span></li>
<li>src/desktoptheme/air/widgets/viewitem.svgz <span style="color: grey">(82f9662)</span></li>
<li>src/desktoptheme/oxygen/CMakeLists.txt <span style="color: grey">(7854234)</span></li>
<li>src/desktoptheme/oxygen/colors <span style="color: grey">(760c109)</span></li>
<li>src/desktoptheme/oxygen/dialogs/background.svgz <span style="color: grey">(50589c5)</span></li>
<li>src/desktoptheme/oxygen/dialogs/kickoff.svgz <span style="color: grey">(994306e)</span></li>
<li>src/desktoptheme/oxygen/dialogs/krunner.svgz <span style="color: grey">(eb4e196)</span></li>
<li>src/desktoptheme/oxygen/metadata.desktop <span style="color: grey">(cb037d1)</span></li>
<li>src/desktoptheme/oxygen/opaque/dialogs/background.svgz <span style="color: grey">(6696739)</span></li>
<li>src/desktoptheme/oxygen/opaque/dialogs/krunner.svgz <span style="color: grey">(a703868)</span></li>
<li>src/desktoptheme/oxygen/opaque/widgets/extender-background.svgz <span style="color: grey">(cfcdc61)</span></li>
<li>src/desktoptheme/oxygen/opaque/widgets/panel-background.svgz <span style="color: grey">(77d20a7)</span></li>
<li>src/desktoptheme/oxygen/opaque/widgets/tooltip.svgz <span style="color: grey">(0c62a03)</span></li>
<li>src/desktoptheme/oxygen/widgets/action-overlays.svgz <span style="color: grey">(3020bff)</span></li>
<li>src/desktoptheme/oxygen/widgets/actionbutton.svgz <span style="color: grey">(8c31c2d)</span></li>
<li>src/desktoptheme/oxygen/widgets/analog_meter.svgz <span style="color: grey">(ddf1acc)</span></li>
<li>src/desktoptheme/oxygen/widgets/arrows.svgz <span style="color: grey">(09f274c)</span></li>
<li>src/desktoptheme/oxygen/widgets/background.svgz <span style="color: grey">(f9e4b1d)</span></li>
<li>src/desktoptheme/oxygen/widgets/bar_meter_horizontal.svgz <span style="color: grey">(6b2eeac)</span></li>
<li>src/desktoptheme/oxygen/widgets/bar_meter_vertical.svgz <span style="color: grey">(6d4c3c9)</span></li>
<li>src/desktoptheme/oxygen/widgets/branding.svgz <span style="color: grey">(70ba236)</span></li>
<li>src/desktoptheme/oxygen/widgets/busywidget.svgz <span style="color: grey">(bcdfc59)</span></li>
<li>src/desktoptheme/oxygen/widgets/button.svgz <span style="color: grey">(4ac759d)</span></li>
<li>src/desktoptheme/oxygen/widgets/calendar.svgz <span style="color: grey">(e784207)</span></li>
<li>src/desktoptheme/oxygen/widgets/clock.svgz <span style="color: grey">(d2ec85e)</span></li>
<li>src/desktoptheme/oxygen/widgets/configuration-icons.svgz <span style="color: grey">(ea73e6a)</span></li>
<li>src/desktoptheme/oxygen/widgets/containment-controls.svgz <span style="color: grey">(675cba4)</span></li>
<li>src/desktoptheme/oxygen/widgets/dragger.svgz <span style="color: grey">(c4f8ce9)</span></li>
<li>src/desktoptheme/oxygen/widgets/extender-background.svgz <span style="color: grey">(7e5afab)</span></li>
<li>src/desktoptheme/oxygen/widgets/extender-dragger.svgz <span style="color: grey">(37c92ec)</span></li>
<li>src/desktoptheme/oxygen/widgets/frame.svgz <span style="color: grey">(7f5ce59)</span></li>
<li>src/desktoptheme/oxygen/widgets/glowbar.svgz <span style="color: grey">(557ff18)</span></li>
<li>src/desktoptheme/oxygen/widgets/line.svgz <span style="color: grey">(f8f3d0e)</span></li>
<li>src/desktoptheme/oxygen/widgets/lineedit.svgz <span style="color: grey">(44b4ab6)</span></li>
<li>src/desktoptheme/oxygen/widgets/media-delegate.svgz <span style="color: grey">(e28b313)</span></li>
<li>src/desktoptheme/oxygen/widgets/monitor.svgz <span style="color: grey">(f005a57)</span></li>
<li>src/desktoptheme/oxygen/widgets/pager.svgz <span style="color: grey">(967015b)</span></li>
<li>src/desktoptheme/oxygen/widgets/panel-background.svgz <span style="color: grey">(13f2f69)</span></li>
<li>src/desktoptheme/oxygen/widgets/plot-background.svgz <span style="color: grey">(439b288)</span></li>
<li>src/desktoptheme/oxygen/widgets/scrollbar.svgz <span style="color: grey">(d8a0557)</span></li>
<li>src/desktoptheme/oxygen/widgets/scrollwidget.svgz <span style="color: grey">(5e38523)</span></li>
<li>src/desktoptheme/oxygen/widgets/slider.svgz <span style="color: grey">(f13f699)</span></li>
<li>src/desktoptheme/oxygen/widgets/systemtray.svgz <span style="color: grey">(ad4e1a2)</span></li>
<li>src/desktoptheme/oxygen/widgets/tasks.svgz <span style="color: grey">(1ffa9d7)</span></li>
<li>src/desktoptheme/oxygen/widgets/timer.svgz <span style="color: grey">(43ceeee)</span></li>
<li>src/desktoptheme/oxygen/widgets/toolbox.svgz <span style="color: grey">(0f92dde)</span></li>
<li>src/desktoptheme/oxygen/widgets/tooltip.svgz <span style="color: grey">(33d0bb5)</span></li>
<li>src/desktoptheme/oxygen/widgets/translucentbackground.svgz <span style="color: grey">(47b418d)</span></li>
<li>src/desktoptheme/oxygen/widgets/viewitem.svgz <span style="color: grey">(cec433e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>