<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126968/">https://git.reviewboard.kde.org/r/126968/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Februar 2nd, 2016, 4:40 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126968/diff/1/?file=442552#file442552line70" style="color: black; font-weight: bold; text-decoration: underline;">effects/morphingpopups/package/contents/code/morphingpopups.js</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">window</span><span class="p">.</span><span class="nx">setData</span><span class="p">(</span><span class="mi">7</span><span class="p">,</span> <span class="kc">true</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">enums (KWin.* should work, but am not sure)</pre>
</blockquote>
<p>On Februar 2nd, 2016, 8:51 nachm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">doesn't seems to work</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Meh - we should wire the enum down to the effect then, using hardcoded integers for this purpose is ugly (and error prone)</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Februar 2nd, 2016, 4:40 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126968/diff/1/?file=442552#file442552line86" style="color: black; font-weight: bold; text-decoration: underline;">effects/morphingpopups/package/contents/code/morphingpopups.js</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">animProgress</span> <span class="o">=</span> <span class="nx">progress</span><span class="p">(</span><span class="nb">window</span><span class="p">.</span><span class="nx">moveAnimation</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a) let's have AnimationEffect::retarget(id, values...)?! - progress is a private detail of AnimationEffect.
if that returns "bool", you also get around the cleanup issue.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">b) something tells me the duration should probably shorten in this case?</p></pre>
</blockquote>
<p>On Februar 2nd, 2016, 8:51 nachm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">will give it a try</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll have to revisit the animationeffect class anyway because of the segfault and will implement a function to retarget an animation, so you don't have to spend too much time on it.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On Februar 2nd, 2016, 8:51 nachm. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2016, 8:51 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=347863">347863</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this effect, derived from the Maximize one, will take the place of the manual window position animation that Plasma tooltip are using.
this should cause less problems as animationg positions on X is very error prone, plus it's less jarring when the tooltip sizes changes too, since that gets animated as well (behavior similar to Window7 taskbar tooltips)
look:
https://www.youtube.com/watch?v=sxE23ZgkkpU
slow motion:
https://www.youtube.com/watch?v=jDByfncO568</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replaces https://git.reviewboard.kde.org/r/126870</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>effects/CMakeLists.txt <span style="color: grey">(dec50a9)</span></li>
<li>effects/backgroundcontrast/contrast.cpp <span style="color: grey">(168deb0)</span></li>
<li>effects/blur/blur.cpp <span style="color: grey">(a360f03)</span></li>
<li>effects/morphingpopups/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/morphingpopups/package/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/morphingpopups/package/contents/code/morphingpopups.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/morphingpopups/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkwineffects/kwinanimationeffect.h <span style="color: grey">(f59eedc)</span></li>
<li>libkwineffects/kwinanimationeffect.cpp <span style="color: grey">(579535b)</span></li>
<li>scripting/scriptedeffect.h <span style="color: grey">(2a77a2f)</span></li>
<li>scripting/scriptedeffect.cpp <span style="color: grey">(7ab065b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126968/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>