<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126953/">https://git.reviewboard.kde.org/r/126953/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 from me</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would it be possible to change the preview to an rectangular preview like in look & feel, splas screen. than the section don't look so bussy and it would fit better to the other design KCM's.</p></pre>
<br />
<p>- andreas kainz</p>
<br />
<p>On February 1st, 2016, 8:15 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, KDE Usability and Andrew Lake.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2016, 8:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This removes the theme editor thing in the Desktop Theme KCM.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Most settings in there are either broken or useless nowadays.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only setting I would miss is different Analog Clock faces which could be done in the Analog Clock directly. What I am missing in general is a custom Panel color/texture or something like that which we don't have in here anyway.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tab gone.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While at it I also replaced the status label with a proper KMessageWidget</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/desktoptheme/CMakeLists.txt <span style="color: grey">(6168686)</span></li>
<li>kcms/desktoptheme/DesktopTheme.ui <span style="color: grey">(f57cdf8)</span></li>
<li>kcms/desktoptheme/DesktopThemeDetails.ui <span style="color: grey">(9df3536)</span></li>
<li>kcms/desktoptheme/desktopthemedetails.h <span style="color: grey">(475d893)</span></li>
<li>kcms/desktoptheme/desktopthemedetails.cpp <span style="color: grey">(ce5c856)</span></li>
<li>kcms/desktoptheme/kcm_desktoptheme_debug.h <span style="color: grey">(e3363f0)</span></li>
<li>kcms/desktoptheme/kcm_desktoptheme_debug.cpp <span style="color: grey">(e09e839)</span></li>
<li>kcms/desktoptheme/kcmdesktoptheme.h <span style="color: grey">(ac87862)</span></li>
<li>kcms/desktoptheme/kcmdesktoptheme.cpp <span style="color: grey">(8991990)</span></li>
<li>kcms/desktoptheme/thememodel.cpp <span style="color: grey">(bb5bb94)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126953/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>