<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126870/">https://git.reviewboard.kde.org/r/126870/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pointing out the obvious: though shall not animate window positions! This needs to be moved to KWin (I'm disappointed that such code still exists in frameworks). Which would kind of solve the problems automatically.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course that comment is orthogonal to this review request: improvement is always good.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126870/diff/2/?file=436482#file436482line160" style="color: black; font-weight: bold; text-decoration: underline;">src/declarativeimports/core/tooltip.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">159</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dlg</span><span class="o">-></span><span class="n">setAnimationsEnabled</span><span class="p">(</span><span class="n">dlg</span><span class="o">-></span><span class="n">isVisible</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dlg</span><span class="o">-></span><span class="n">setAnimationsEnabled</span><span class="p">(</span><span class="n"><span class="hl">KWindowSystem</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">compositingActive</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span><span class="hl"> </span><span class="n">dlg</span><span class="o">-></span><span class="n">isVisible</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why bind it to compositingActive?</p></pre>
</div>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 24th, 2016, 4:20 p.m. CET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma and David Edmundson.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 4:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=354353">354353</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Continous usage, read as suspend/resume/use and so on, cause <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cool</em> tooltip animation transition between item to decrease it permormance and looks quite ugly. If add new panel animation is <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cool</em> as is. The perfermonce decrease can be cause due to swap use, or QPropertyAnimation issue, however we (you KDE defs and i <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">like a user</em>) wants plasmashell and it's components (like panel) to works <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">forever</em></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Workaround is quite simple:
Animation is refreshed as is, pointer hasn't same lifetime as panel
+ Animation is disabled if compositing is not active</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/tooltip.cpp <span style="color: grey">(a5e223b)</span></li>
<li>src/declarativeimports/core/tooltipdialog.h <span style="color: grey">(2ea8af9)</span></li>
<li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: grey">(6c3712e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126870/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>