<div dir="ltr"><div>Hi Weng Xeutian,<br><br></div>Any ideas on the below mentioned issue?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 19, 2016 at 8:09 PM, Rajeesh K V <span dir="ltr"><<a href="mailto:rajeeshknambiar@gmail.com" target="_blank">rajeeshknambiar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
<table style="border:1px #c9c399 solid;border-radius:6px" width="100%" bgcolor="#f9f3c9" cellpadding="12">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126807/" target="_blank">https://git.reviewboard.kde.org/r/126807/</a>
</td>
</tr>
</tbody></table>
<br>
</span><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"><span class="">
<p style="margin-top:0">On January 19th, 2016, 6:35 p.m. UTC, <b>Rajeesh K V</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">I must admit I don't understand the root cause or how m_connection could be null, but as this fixes the crash - ship it.</p></pre>
</blockquote>
</span><span class=""><p>On January 19th, 2016, 6:43 p.m. UTC, <b>Andreas Cord-Landwehr</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">If I am not mistaken, the root cause is the following:
<em style="padding:0;margin:0;line-height:inherit;white-space:normal"> XLibTouchpad has a member variable m_touchpadOffAtom
</em> this variable is created by the default constructor that sets the connection to 0
* no m_touchpadOffAtom.intern(...) call is performed to set the connection, so it remains 0
The question now for me is, what are the correct parameters for m_touchpadOffAtom.inter(...). On the one hand it should be m_connection, on the other hand I do not know what the parameter "name" should name. The correct position would be IMO plasma-desktop/kcms/touchpad/src/backends/x11/xlibtouchpad.cpp line 266 to make this call.</p></pre>
</blockquote>
</span></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Ok, I see the issue now.
The actual backends - libinput and synaptics sets their m_touchpadOffAtom with respective properties. The new class XlibTouchpad does not initialize its m_touchpadOffAtom in constructor. I'm not sure with what property it should be initialized with. Adding Weng Xeutian for more details.</p></pre><span class="HOEnZb"><font color="#888888">
<br>
<p>- Rajeesh</p></font></span><span class="">
<br>
<p>On January 19th, 2016, 9:24 a.m. UTC, Andreas Cord-Landwehr wrote:</p>
<table style="border:1px #888a85 solid;border-radius:6px" width="100%" bgcolor="#fefadf" cellpadding="12" cellspacing="0">
<tbody><tr>
<td>
<div>Review request for Plasma and Alexander Mezin.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color:grey"><i>Updated Jan. 19, 2016, 9:24 a.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=357907" target="_blank">357907</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
plasma-desktop
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">This is an attempt to fix the crash reported at <a href="https://bugs.kde.org/show_bug.cgi?id=357907" target="_blank">https://bugs.kde.org/show_bug.cgi?id=357907</a>.
Yet, I am neither familiar with the code nor with using XCB. So I cannot judge if this is only a workaround or a proper fix.</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Solves the crashes for me.</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kcms/touchpad/src/backends/x11/xcbatom.cpp <span style="color:grey">(06f7f52)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126807/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</span></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Rajeesh<br><a href="http://rajeeshknambiar.wordpress.com" target="_blank">http://rajeeshknambiar.wordpress.com</a><br><br></div></div>
</div>