<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126730/">https://git.reviewboard.kde.org/r/126730/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 13th, 2016, 9:52 a.m. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, this KCM is not designed according the HIG. It could look like this http://i.imgur.com/TVAZBFl.png. Enhancement idea to the existing HIG is a horizontal splitter left of "more" that allows to enlarge either the upper area to see more than just a few items in the list or to have more space for the advanced options.
About the content I wonder why someone would want to change the cursor at this point of the login. And User would be some kind of restriction allowing only a range of users to login, if I get this right. Makes not much sense to me, however. But anyway, it would be added below the other stuff - my mockup cuts the content there for lazyness purpose :-).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A remark regarding the existing KCM: it takes a lot of space and probably I'm not the only one who tries to resize the left part. My suggestion is to add a vertical splitter. And maybe the right part for customization could be smaller by default.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: KCMs should indicate if the execution needs elevated user rights. No idea how at the moment.</p></pre>
</blockquote>
<p>On January 13th, 2016, 7:53 p.m. UTC, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">thanks for your comment I like your KCM Style when I know more about cpp and qml I will come back and look that I can make the SDDM KCM like you wrote.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: I'm flattered to be a trusted reviewer, but addressing "usability" may get more opinions.</p></pre>
<br />
<p>- Heiko</p>
<br />
<p>On January 13th, 2016, 7:50 p.m. UTC, andreas kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Heiko Tietze.</div>
<div>By andreas kainz.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2016, 7:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sddm-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove the webpage and the author in the overview cause this is shown in the preview section.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">after this cleanup there is one point open but therefore I need someone with real coding skills.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KCM HIG https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">don't use tabs -> add an more button.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So you have an select area and an preview area as in my point of view the Auto Login is an "standard setting" I would add the auto login section on bottom of the select area.
On the bottom page you have an botton
- use userdefined background
- advanced setting
- import from file (now not available)
- import from GHNS (now not available)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/themesdelegate.cpp <span style="color: grey">(1b528a0)</span></li>
<li>src/ui/advanceconfig.ui <span style="color: grey">(e7fcb97)</span></li>
<li>src/ui/themeconfig.ui <span style="color: grey">(33cc685)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126730/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/13/483cf282-99b2-4c26-ab51-0d415d3fdf5e__sddm-kcm.png">sddm-kcm.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>